[test_bgp_peer_down.py] Enhance BGP peer shutdown test for new neighbor types - #26744
Closed
wenyiz2021 wants to merge 1 commit into
Closed
[test_bgp_peer_down.py] Enhance BGP peer shutdown test for new neighbor types#26744wenyiz2021 wants to merge 1 commit into
wenyiz2021 wants to merge 1 commit into
Conversation
Added handling for LowerMgmtAggregator and UpperMgmtAggregator types in BGP peer shutdown test.
Collaborator
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates tests/bgp/test_bgp_peer_shutdown.py to recognize management-aggregator DUT roles and adjust how the test neighbor is modeled/configured when BGP confederation is involved, aiming to ensure the shutdown behavior is validated correctly on these newer neighbor types.
Changes:
- Extend
common_setup_teardownDUT-type classification to includeLowerMgmtAggregatorandUpperMgmtAggregator. - Assign the neighbor type
MgmtSpineRouterfor these DUT types. - Enable configuring the test neighbor via
vtysh(instead of CONFIG_DB) when a confederation ASN is present.
Comment on lines
+82
to
+86
| # external eBGP peer, so it must be added directly to FRR via vtysh | ||
| # (the config_db path is not rendered for these peers). | ||
| neigh_type = "MgmtSpineRouter" | ||
| if confed_asn is not None: | ||
| use_vtysh = True |
wenyiz2021
changed the title
Contributor
Author
|
adding in #26750 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the BGP peer shutdown test logic to correctly handle management aggregator devices that use BGP confederation. The main change ensures that when the device under test is a management aggregator, the test neighbor is treated as an external eBGP peer and is configured directly via
vtysh.BGP confederation handling improvements:
common_setup_teardownintests/bgp/test_bgp_peer_shutdown.pyto recognizeLowerMgmtAggregatorandUpperMgmtAggregatordevice types, setting the neighbor type toMgmtSpineRouterand ensuring external eBGP peers are added viavtyshwhen confederation is present.Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation