Skip to content

Add cdb_supported to expected keys in test_sfp.py - #26662

Open
bgallagher-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:cdb-support-test
Open

Add cdb_supported to expected keys in test_sfp.py#26662
bgallagher-nexthop wants to merge 1 commit into
sonic-net:masterfrom
nexthop-ai:cdb-support-test

Conversation

@bgallagher-nexthop

Copy link
Copy Markdown

Description of PR

sonic-net/sonic-platform-common#721 adds a new key to get_transceiver_info called cdb_supported that indicates whether a transceiver advertises CDB support.

Summary:
Once sonic-net/sonic-platform-common#721 merges, cdb_supported will always be returned by CmisApi.get_transceiver_info. This test needs to be updated to reflect that or else it will fail.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202311
  • 202405
  • 202411
  • 202505
  • 202511
  • 202512
  • 202605

Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): N/A
Failure type: N/A

Tested branch

  • master
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511
  • 202512
  • 202605
  • N/A

Test result

The test passes.

Approach

What is the motivation for this PR?

Making this change to ensure the tests within test_sfp.py continue to pass.

How did you do it?

Added cdb_supported as a key that the test expects to see.

How did you verify/test it?

Ran the test.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@bgallagher-nexthop
bgallagher-nexthop marked this pull request as ready for review July 29, 2026 19:02
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

---Powered by SONiC BuildBot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants