Add cdb_supported to expected keys in test_sfp.py - #26662
Open
bgallagher-nexthop wants to merge 1 commit into
Open
Add cdb_supported to expected keys in test_sfp.py#26662bgallagher-nexthop wants to merge 1 commit into
bgallagher-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
bgallagher-nexthop
marked this pull request as ready for review
July 29, 2026 19:02
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
github-actions
Bot
requested review from
rawal01,
xwjiang-ms and
yutongzhang-microsoft
July 29, 2026 19:03
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
sonic-net/sonic-platform-common#721 adds a new key to
get_transceiver_infocalledcdb_supportedthat indicates whether a transceiver advertises CDB support.Summary:
Once sonic-net/sonic-platform-common#721 merges,
cdb_supportedwill always be returned byCmisApi.get_transceiver_info. This test needs to be updated to reflect that or else it will fail.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): N/A
Failure type: N/A
Tested branch
Test result
The test passes.
Approach
What is the motivation for this PR?
Making this change to ensure the tests within
test_sfp.pycontinue to pass.How did you do it?
Added
cdb_supportedas a key that the test expects to see.How did you verify/test it?
Ran the test.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A