[action] [PR:24329] [conditional_mark] Skip gnmi/test_gnmic.py - #24336
Closed
mssonicbld wants to merge 1 commit into
Closed
[action] [PR:24329] [conditional_mark] Skip gnmi/test_gnmic.py#24336mssonicbld wants to merge 1 commit into
mssonicbld wants to merge 1 commit into
Conversation
## Description of PR Add a conditional-mark `skip` for `tests/gnmi/test_gnmic.py` while the `gnmic` binary is being removed from `docker-ptf`. This is a precondition for the companion `docker-ptf` change that drops `gnmic` from the image. `tests/gnmi/test_gnmic.py` is the only test in this repo that invokes `/usr/local/bin/gnmic` directly (via `PtfGnmic.capabilities()`); without this skip, that test would start failing on the next `docker-ptf` rebuild. ## Summary Fixes # (issue): sonic-net#24328 ## Type of change - [x] Test case (verification of existing or new feature) ## Back port request - [ ] Request back port to applicable release branches (master only — no behavior change for release branches that don't run this test) ## Approach ### What is the motivation for this PR? Reduce `docker-ptf` supply-chain surface. `gnoic` was removed in [sonic-buildimage#27055](sonic-net/sonic-buildimage#27055); `gnmic` is the next candidate because it has only one consumer in sonic-mgmt and that consumer can be skipped without losing coverage of any production behavior — `gnmi_tls.gnoi.*` and `pygnmi` cover the actual gNMI/gNOI surfaces under test. ### How did you do it? Added an entry under the `gnmi/` section of `tests_mark_conditions.yaml` that skips the test while sonic-net#24328 is open. When the issue closes, the skip lifts — by then we should have either deleted the test outright or restored `gnmic`. ### How did you verify/test it? - `yaml.safe_load` parses the file cleanly with the new entry present. - conditional_mark plugin uses `pytest_collection_modifyitems`; no test execution required to confirm marker application — the existing `unit_test/` suite under `tests/common/plugins/conditional_mark/` covers that mechanism. ## Any platform specific information? None. ## Supported testbed topology if it's a new test case? N/A — no test added. ## Documentation N/A. Signed-off-by: Dawei Huang <daweihuang@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
2 tasks
Collaborator
Author
|
Original PR: #24329 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
April 30, 2026 04:42
Contributor
|
/azpw retry |
Collaborator
Author
|
Retrying failed(or canceled) jobs... |
Collaborator
Author
|
Retrying failed(or canceled) stages in build 1102061: ✅Stage Test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Add a conditional-mark
skipfortests/gnmi/test_gnmic.pywhile thegnmicbinary is being removed fromdocker-ptf.This is a precondition for the companion
docker-ptfchange that dropsgnmicfrom the image.tests/gnmi/test_gnmic.pyis the only test in this repo that invokes/usr/local/bin/gnmicdirectly (viaPtfGnmic.capabilities()); without this skip, that test would start failing on the nextdocker-ptfrebuild.Summary
Fixes # (issue): #24328
Type of change
Back port request
Approach
What is the motivation for this PR?
Reduce
docker-ptfsupply-chain surface.gnoicwas removed in sonic-buildimage#27055;gnmicis the next candidate because it has only one consumer in sonic-mgmt and that consumer can be skipped without losing coverage of any production behavior —gnmi_tls.gnoi.*andpygnmicover the actual gNMI/gNOI surfaces under test.How did you do it?
Added an entry under the
gnmi/section oftests_mark_conditions.yamlthat skips the test while #24328 is open. When the issue closes, the skip lifts — by then we should have either deleted the test outright or restoredgnmic.How did you verify/test it?
yaml.safe_loadparses the file cleanly with the new entry present.pytest_collection_modifyitems; no test execution required to confirm marker application — the existingunit_test/suite undertests/common/plugins/conditional_mark/covers that mechanism.Any platform specific information?
None.
Supported testbed topology if it's a new test case?
N/A — no test added.
Documentation
N/A.