Skip to content

vpp: Enable test_nhop_group.py - #23175

Merged
auspham merged 2 commits into
sonic-net:masterfrom
yue-fred-gao:enable_test_nhop_group
Mar 26, 2026
Merged

vpp: Enable test_nhop_group.py#23175
auspham merged 2 commits into
sonic-net:masterfrom
yue-fred-gao:enable_test_nhop_group

Conversation

@yue-fred-gao

@yue-fred-gao yue-fred-gao commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Properly categorize test cases in ipfwd/test_nhop_group.py.

How did you do it?

  1. Previously some test cases are marked "to be included". This PR properly skip the ones that are not supported and give proper reason. PR vpp: Implement ordered ecmp capability report sonic-sairedis#1802 is submitted to report supported ecmp type in capability advertisement.
  2. Enable test_nhop_group_member_count test case. This depends on PR vpp: implement CRM counters for neighbour, nexthop, nexthop group and members sonic-sairedis#1814 to provide CRM support in sonic-vpp.

How did you verify/test it?

Run sonic-mgmt test

Any platform specific information?

vpp

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Yue Gao <yuega2@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

auspham
auspham previously approved these changes Mar 24, 2026
Signed-off-by: Yue Gao <yuega2@cisco.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@github-actions
github-actions Bot requested review from BYGX-wcr and xwjiang-ms March 25, 2026 19:09
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@auspham
auspham merged commit 388d626 into sonic-net:master Mar 26, 2026
18 checks passed
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202603: Azure/sonic-mgmt.msft#1095

selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Apr 1, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Apr 3, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Apr 20, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Jun 11, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
ssithaia-ebay pushed a commit to ssithaia-ebay/sflow-yang-sonic-mgmt that referenced this pull request Jul 21, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: ssithaia-ebay <ssithaian@ebay.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jul 22, 2026
* Enable test_nhop_group.py for vpp

Signed-off-by: Yue Gao <yuega2@cisco.com>

* Undo change to test_nhop_group.py since vpp supports crm

Signed-off-by: Yue Gao <yuega2@cisco.com>

---------

Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: Yael Tzur <ytzur@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants