Updating go.mod & go.sum - Dependency for https://github.com/sonic-net/sonic-mgmt-common/pull/182 - #150
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@maipbui @anand-kumar-subramanian @qiluo-msft @kwangsuk @saiarcot895 @amrutasali @yejianquan Please help in review and merge |
3 similar comments
|
@maipbui @anand-kumar-subramanian @qiluo-msft @kwangsuk @saiarcot895 @amrutasali @yejianquan Please help in review and merge |
|
@maipbui @anand-kumar-subramanian @qiluo-msft @kwangsuk @saiarcot895 @amrutasali @yejianquan Please help in review and merge |
|
@maipbui @anand-kumar-subramanian @qiluo-msft @kwangsuk @saiarcot895 @amrutasali @yejianquan Please help in review and merge |
sonic-buildimage : #23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine Signed-off-by: Feng Pan <fenpan@microsoft.com>
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine Signed-off-by: mhchann <mhchann082@gmail.com>
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
|
Hi @yxieca @vaibhavhd @maipbui @anand-kumar-subramanian @qiluo-msft @kwangsuk @saiarcot895 @amrutasali @yejianquan - the author has attempted multiple times to request for review. Could you suggest reviewers or help review? |
|
Thanks for approving @kwangsuk , could we merge this in? |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
3 similar comments
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
10 similar comments
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @Verma-Anukul , looks like the DCO checks are failing due to lack of sign off in commit messages. Could you update the commit messages for all the commits in this PR? |
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
10 similar comments
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
@Verma-Anukul, the DCO checks are failing due to lack of sign off in commit messages. Could you please update the commit messages for both commits to pass this check? |
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
5 similar comments
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
|
Hi @sonic-net/sonic-mgmt-framework-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks! ---Powered by SONiC BuildBot
|
6 participants
Dependency: SONiC Yang changes in sonic-buildimage : sonic-net/sonic-buildimage#23401
sonic-mgmt-framework - #150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182
HLD : sonic-net/SONiC#1790
Dependency: SONiC Yang changes in sonic-buildimage : sonic-net/sonic-buildimage#23401
Added Annotation, xfmr support for oc-system module
Also included go test for all the xpaths supported
Features included -
hostname
login & motd banner
timezone
dns
ntp
ssh-server
logging
aaa
processes
messages