fix: upgrade vulnerable Go dependencies to fix CRITICAL/HIGH CVEs - #239
Closed
qiluo-msft wants to merge 2 commits into
Closed
fix: upgrade vulnerable Go dependencies to fix CRITICAL/HIGH CVEs#239qiluo-msft wants to merge 2 commits into
qiluo-msft wants to merge 2 commits into
Conversation
- google.golang.org/grpc v1.28.0 -> v1.82.1 (CVE-2026-33186, GHSA-hrxh-6v49-42gf) - golang.org/x/text v0.3.3 -> v0.39.0 (CVE-2020-14040, CVE-2021-38561, CVE-2026-56852) - antchfx/xpath v1.1.10 -> v1.3.6 (CVE-2026-32287, direct dependency) - antchfx/jsonquery v1.1.4 -> v1.3.7 (parent of vulnerable xpath) - antchfx/xmlquery v1.3.1 -> v1.5.1 (parent of vulnerable xpath) Signed-off-by: qiluo <qiluo@microsoft.com>
Signed-off-by: qiluo <qiluo@microsoft.com>
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Updates Go module dependencies in sonic-mgmt-common to remediate Trivy-reported CRITICAL/HIGH CVEs by bumping several direct dependencies (notably gRPC, x/text, and antchfx XPath stack) and refreshing the module sums.
Changes:
- Bump direct dependencies:
google.golang.org/grpc,golang.org/x/text, andgithub.com/antchfx/{jsonquery,xmlquery,xpath}to newer, non-vulnerable versions. - Refresh
go.sumto match the updated dependency graph after module tidy/vendor regeneration. - Update additional dependency/tooling pins implied by the upgrade (e.g.,
github.com/golang/glog, indirect modules, and thegodirective).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates direct/indirect module versions (including gRPC, x/text, antchfx stack) and bumps the go directive. |
| go.sum | Regenerates module checksums to reflect the updated dependency graph. |
Suppressed comments (3)
go.mod:10
github.com/golang/glogis also patched during the vendoring step (patches/apply.sh applies patches/glog.patch). With the version bump here, the patch may need to be refreshed; otherwise the build can fail when applying patches. Please ensure the patch still applies to v1.2.5 (and update the patch if needed).
github.com/golang/glog v1.2.5
go.mod:10
- PR description lists only grpc/x/text/antchfx upgrades, but this file also bumps
github.com/golang/glogand the Go toolchain version. Please update the PR description (and CVE impact notes, if relevant) to reflect these additional changes so reviewers/consumers understand the full upgrade surface.
github.com/golang/glog v1.2.5
go.mod:40
- Bumping the module
godirective to 1.25.0 forces all builds (including CI) to use Go >= 1.25; older toolchains will error out beforego mod vendorruns. Unless there is a hard requirement from updated deps, consider keeping thegodirective at the previously supported version, or update the CI/build container/toolchain accordingly.
go 1.25.0
Comment on lines
+5
to
+7
| github.com/antchfx/jsonquery v1.3.7 | ||
| github.com/antchfx/xmlquery v1.5.1 | ||
| github.com/antchfx/xpath v1.3.6 |
Author
|
Superseded by updated PR addressing glog patch compatibility and go directive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Trivy CVE scan identified multiple CRITICAL and HIGH severity vulnerabilities in the Go module dependencies of sonic-mgmt-common.
How I did it
Updated
go.modand regeneratedgo.sumviago mod tidywith the following version bumps:google.golang.org/grpcgolang.org/x/textgithub.com/antchfx/xpathgithub.com/antchfx/jsonquerygithub.com/antchfx/xmlqueryHow to verify it
trivy fs . --severity CRITICAL,HIGHCRITICAL count should drop to 0 for these packages; HIGH count should decrease substantially.