[ci]: Install libyang3 for linkmgrd builds - #345
Merged
zjswhhh merged 1 commit intoJun 15, 2026
Conversation
Signed-off-by: Jing Zhang <zhangjing@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ndancejic
approved these changes
Jun 15, 2026
| patterns: | | ||
| target/debs/bookworm/libyang_*.deb | ||
| target/debs/bookworm/libyang3_*.deb | ||
| target/debs/bookworm/libyang-dev_*.deb |
There was a problem hiding this comment.
Nit: suggest pattern libyang-dev_3*.deb for the dev headers package instead. Shouldn't affect functionality since libyang1 is no longer being built anyways
theasianpianist
approved these changes
Jun 15, 2026
Collaborator
|
Cherry-pick PR to 202605: #347 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
linkmgrd CI currently assumes the common-lib artifact contains
libyang_*.deb, but the current SONiC common-lib artifact publisheslibyang3_*.debandlibyang-dev_*.deb. This causes Azure to download zero packages and then fail withdpkg --install needs at least one package archive file argument.CodeQL also downloads
libswsscommonwithout extracting the matching SONiClibyang3, so the link step cannot resolvelibyang.so.3.How I did it
libyang3_*.debandlibyang-dev_*.deb.libyang3packages in CodeQL before building against downloadedlibswsscommon.-Wl,-rpath-linkfor the extracted library directory so CodeQL's linker can resolvelibyang.so.3.How to verify it
sonic-linkmgrdpipeline.ly_*symbols fromlibswsscommon.