Skip to content

azure-pipelines: migrate libyang1 deb install to libyang3 #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhouse-nexthop wants to merge 3 commits into from
Closed

azure-pipelines: migrate libyang1 deb install to libyang3 #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b47af5
azure-pipelines: migrate libyang1 deb install to libyang3
bhouse-nexthop May 31, 2026
0061c11
ci(codeql): link against libyang3 instead of distro libyang1
bhouse-nexthop Jun 15, 2026
e6734af
ci(codeql): set LD_LIBRARY_PATH so ld resolves indirect libyang.so.3
bhouse-nexthop Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
libnl-genl-3-dev \
libnl-route-3-dev \
libnl-nf-3-dev \
libyang-dev \
libzmq3-dev \
libzmq5 \
swig3.0 \
Expand Down Expand Up @@ -131,7 +130,18 @@ jobs:
exit 0
fi

rm -rf /tmp/swss-common /tmp/swss-common.zip
# libswsscommon is built against libyang3 (libyang.so.3); the distro
# apt libyang on this runner is libyang1, so the link would fail with
# "libyang.so.3 ... not found". Stage the libyang3 debs into the same
# prefix as swss-common. The sonic-build artifacts REST API requires an
# exact filename (wildcards do not resolve), so fetch the bookworm debs
# directory as a zip and extract just the libyang3 debs with a glob to
# stay version-independent across libyang3 bumps.
curl -sL -o /tmp/bookworm-debs.zip "https://sonic-build.azurewebsites.net/api/sonic/artifacts?branchName=master&platform=vs&target=target/debs/bookworm&format=zip"
unzip -j -o /tmp/bookworm-debs.zip '*/libyang3_*.deb' '*/libyang-dev_*.deb' -d /tmp/libyang
for d in /tmp/libyang/*.deb; do dpkg-deb -x "$d" $(dirname $GITHUB_WORKSPACE); done

rm -rf /tmp/swss-common /tmp/swss-common.zip /tmp/libyang /tmp/bookworm-debs.zip
echo "installed=true" >> "$GITHUB_OUTPUT"
env:
SWSSCOMMON_VER: "1.0.0"
Expand All @@ -143,6 +153,10 @@ jobs:
sed -i "/JOBS := \$(subst -j,,\$(JOB_FLAG))/a JOBS := 1" Makefile
sed -i -e "s/ -flto//g" Makefile
sed -i '/-include objects.mk/a LIBS := -L'"$(dirname $GITHUB_WORKSPACE)"'/usr/lib/x86_64-linux-gnu \$(LIBS)' Makefile
# libswsscommon.so pulls in libyang.so.3 as an indirect dependency. ld
# does not search -L paths for indirect deps, only -rpath-link and
# LD_LIBRARY_PATH, so point it at the staged libyang3 in the prefix.
export LD_LIBRARY_PATH="$(dirname $GITHUB_WORKSPACE)/usr/lib/x86_64-linux-gnu${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}"
make all INCLUDES="-L$(dirname $GITHUB_WORKSPACE)/usr/lib/x86_64-linux-gnu -I$(dirname $GITHUB_WORKSPACE)/usr/include"

- name: Perform CodeQL Analysis
Expand Down
6 changes: 3 additions & 3 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
path: $(Build.ArtifactStagingDirectory)/download
artifact: common-lib
patterns: |
target/debs/bookworm/libyang_*.deb
target/debs/bookworm/libyang3_*.deb
displayName: "Download libyang from common lib"
- script: |
set -ex
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
path: $(Build.ArtifactStagingDirectory)/download
artifact: common-lib.arm64
patterns: |
target/debs/bookworm/libyang_*.deb
target/debs/bookworm/libyang3_*.deb
displayName: "Download libyang from common lib"
- script: |
set -ex
Expand Down Expand Up @@ -275,7 +275,7 @@ jobs:
path: $(Build.ArtifactStagingDirectory)/download
artifact: common-lib.armhf
patterns: |
target/debs/bookworm/libyang_*.deb
target/debs/bookworm/libyang3_*.deb
displayName: "Download libyang from common lib"
- script: |
set -ex
Expand Down
Loading