[sonic-buildimage]: fix CRITICAL/HIGH CVEs in Go module dependencies - #28890
Open
qiluo-msft wants to merge 1 commit into
Open
[sonic-buildimage]: fix CRITICAL/HIGH CVEs in Go module dependencies#28890qiluo-msft wants to merge 1 commit into
qiluo-msft wants to merge 1 commit into
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remediate CRITICAL/HIGH CVEs in Go module dependencies by updating the submodule pins in sonic-buildimage so builds consume newer dependency sets from the corresponding upstream repositories.
Changes:
- Bump
src/sonic-gnmisubmodule pointer. - Bump
src/sonic-mgmt-commonsubmodule pointer. - Bump
src/sonic-sysmgr/gnoisubmodule pointer. - Add a new
src/sonic-telemetrygitlink (submodule pointer).
Key review findings (blocking):
- The new submodule SHAs referenced for
sonic-gnmi,sonic-mgmt-common, andgnoiare not resolvable in their respective upstream repos, which will breakgit submodule update --initand therefore the build. src/sonic-telemetryis introduced as a new submodule, but there is no corresponding.gitmodulesentry in this PR; submodule initialization/checkout will not work as-is.- Build rules in this repo already source “telemetry” from
src/sonic-gnmi(notsrc/sonic-telemetry), andsonic-net/sonic-telemetryis archived/migrated—so adding a telemetry submodule does not appear to align with how this repo actually builds telemetry today.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/sonic-gnmi | Updates the pinned submodule commit for sonic-gnmi. |
| src/sonic-mgmt-common | Updates the pinned submodule commit for sonic-mgmt-common. |
| src/sonic-sysmgr/gnoi | Updates the pinned submodule commit for the gNOI dependency. |
| src/sonic-telemetry | Adds a new gitlink intended to pin sonic-telemetry. |
Update submodule pointers for sonic-gnmi and sonic-mgmt-common to commits that upgrade vulnerable Go dependencies. Changes per submodule: - sonic-gnmi: grpc v1.64.1->v1.82.1, x/crypto v0.24.0->v0.52.0, x/net v0.26.0->v0.55.0, x/text v0.16.0->v0.39.0, antchfx/xpath v1.1.10->v1.3.6 (CVE-2026-32287) - sonic-mgmt-common: grpc v1.28.0->v1.82.1, x/text v0.3.3->v0.39.0, antchfx/xpath v1.1.10->v1.3.6 (direct dep) Notes: - sonic-telemetry (Azure/sonic-telemetry) is archived/read-only; fix applied locally only - sonic-sysmgr/gnoi (openconfig/gnoi) is third-party; no push access - Separate PRs needed in sonic-gnmi and sonic-mgmt-common submodule repos CVEs fixed: CVE-2026-33186, GHSA-hrxh-6v49-42gf, CVE-2026-32287, CVE-2024-45337, CVE-2025-22869, CVE-2026-39828-39832, CVE-2023-39325, CVE-2024-45338, CVE-2026-25681, CVE-2026-33814, CVE-2026-39821, CVE-2020-14040, CVE-2021-38561, CVE-2022-32149, CVE-2026-56852 Signed-off-by: qiluo <qiluo@microsoft.com>
qiluo-msft
force-pushed
the
fix/cve-remediation-go-modules-2026-08
branch
from
August 6, 2026 23:29
818293e to
c867d30
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Trivy CVE scan of the sonic-buildimage source tree identified 9 CRITICAL and 150 HIGH severity vulnerabilities. This PR updates Go module dependencies in first-party SONiC submodules to remediate the most impactful CRITICAL and HIGH findings.
Work item tracking
N/A
How I did it
Updated submodule pointers for sonic-gnmi and sonic-mgmt-common to commits that upgrade vulnerable Go dependencies. See linked submodule PRs:
sonic-gnmi (sonic-net/sonic-gnmi#741)
google.golang.org/grpcv1.69.2 → v1.82.1 (CVE-2026-33186, GHSA-hrxh-6v49-42gf)golang.org/x/cryptov0.36.0 → v0.52.0 (CVE-2024-45337, CVE-2025-22869, CVE-2026-39828–39832)golang.org/x/netv0.38.0 → v0.55.0 (CVE-2023-39325, CVE-2024-45338, CVE-2026-25681, CVE-2026-33814, CVE-2026-39821)golang.org/x/textv0.23.0 → v0.39.0 (CVE-2026-56852)github.com/antchfx/xpathv1.1.10 → v1.3.6 (CVE-2026-32287)sonic-mgmt-common (sonic-net/sonic-mgmt-common#237)
google.golang.org/grpcv1.28.0 → v1.82.1 (CVE-2026-33186)golang.org/x/textv0.3.3 → v0.39.0 (CVE-2020-14040, CVE-2021-38561, CVE-2022-32149, CVE-2026-56852)github.com/antchfx/xpathv1.1.10 → v1.3.6 (CVE-2026-32287, direct dependency)Known limitations
sonic-telemetry(Azure/sonic-telemetry) is archived/read-onlysonic-sysmgr/gnoi(openconfig/gnoi) is third-party with no push accessHow to verify it
After submodule PRs are merged and this PR's submodule pointers are updated to the merge commits, run:
Which release branch to backport
Tested branch
Local Trivy scan on sonic-buildimage master
Description for the changelog
Remediate CRITICAL/HIGH CVEs: upgrade grpc, golang.org/x/{crypto,net,text}, and antchfx/xpath in sonic-gnmi and sonic-mgmt-common Go modules.