feat: add pynng support for docker-ptf by auspham · Pull Request #27777 · sonic-net/sonic-buildimage

auspham · 2026-06-09T07:13:49Z

Why I did it

PTF tests on scale topologies frequently fail with nnpy.errors.NNError: Connection timed out coming from ptf_nn_agent.py.

Upstream p4lang/ptf has already replaced nnpy with pynng (p4lang/ptf#234). SONiC tried to pick this up but had to pin ptf_nn_agent.py back to an older nnpy-compatible commit in #26912, because docker-ptf did not ship the pynng package.

This PR adds pynng to docker-ptf and moves the Python 3 image's ptf_nn_agent.py onto the upstream pynng-based agent, aligning SONiC with p4lang/ptf master and unblocking the migration off nnpy.

Work item tracking

Microsoft ADO (number only): 38213269

How I did it

In dockers/docker-ptf/Dockerfile.j2, gated the change on PTF_ENV_PY_VER so the two PTF images keep working independently:

py3 image (default): install pynng into the virtualenv, and fetch ptf_nn_agent.py from p4lang/ptf master (the pynng-based agent).
mixed image (legacy Python 2 / buster): unchanged — keeps nnpy and the nnpy-pinned agent commit from chore: pin ptf_nn_agent.py to use nnpy #26912, because pynng requires Python 3.7+ and the agent there runs under Python 2.

docker-ptf-sai builds FROM docker-ptf, so it inherits the change automatically.

How to verify it

Build the PTF image:

make configure PLATFORM=vs
make target/docker-ptf.gz

Start the container and confirm the agent dependency is present and the agent is running:

docker run --rm -it docker-ptf bash
python -c "import pynng; print(pynng.__version__)"
grep -n "import pynng" /opt/ptf_nn_agent.py
supervisorctl status ptf_nn_agent      # -> RUNNING

Run a PTF test that exercises the nn agent on a scale topology and confirm there is no nnpy.errors.NNError: Connection timed out.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

[docker-ptf]: Add pynng package and move py3 ptf_nn_agent off nnpy to pynng (aligns with p4lang/ptf master; addresses NNError connection timeouts on scale topologies)

Link to config_db schema for YANG module changes

N/A — no YANG/config_db changes.

Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>

mssonicbld · 2026-06-09T07:13:57Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-06-09T07:14:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This PR updates the docker-ptf container build to support the newer PTF nn-agent transport by adding pynng for the Python 3 PTF environment and selecting a different upstream ptf_nn_agent.py depending on the PTF Python env.

Changes:

Fetch ptf_nn/ptf_nn_agent.py from different upstream refs depending on PTF_ENV_PY_VER (mixed vs py3).
Install pynng in the py3 PTF environment.

+{# ptf_nn_agent.py is pinned per Python env: the "mixed" image runs the agent
+   under Python 2 (nnpy), so it stays on the last nnpy-compatible upstream
+   commit; the py3 image ships pynng and tracks a p4lang/ptf main commit that
+   uses pynng (see #26912 / upstream p4lang/ptf#234). #}


+{% if PTF_ENV_PY_VER == "mixed" %}
    && wget https://raw.githubusercontent.com/p4lang/ptf/23ebe7237f3c284032bda02fbd1f4a98f1bc12f4/ptf_nn/ptf_nn_agent.py
+{% else %}
+    && wget https://raw.githubusercontent.com/p4lang/ptf/main/ptf_nn/ptf_nn_agent.py


+{% if PTF_ENV_PY_VER == "py3" %}
+    && pip3 install pynng   \
+{% endif %}


mssonicbld · 2026-06-15T00:10:18Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-06-15T00:10:30Z

Azure Pipelines successfully started running 1 pipeline(s).

weiguo-nvidia · 2026-06-23T07:54:08Z

Hi @auspham

Could you help merge the fix?

auspham · 2026-06-26T05:23:08Z

/azpw retry

mssonicbld · 2026-06-26T05:23:10Z

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-26T05:23:12Z

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

auspham · 2026-06-26T05:23:39Z

@weiguo-nvidia the test is still failing, so i cant merge yet

mssonicbld · 2026-06-26T05:23:50Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-06-26T05:24:03Z

Azure Pipelines successfully started running 1 pipeline(s).

auspham · 2026-06-29T00:16:48Z

/azpw retry

mssonicbld · 2026-06-29T00:16:50Z

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-29T00:16:53Z

Retrying failed(or canceled) stages in build 1149409:

✅Stage Test:

Job impacted-area-kvmtest-t1-lag-vpp by Elastictest: retried.

auspham · 2026-06-29T06:34:44Z

/azpw retry

mssonicbld · 2026-06-29T06:34:46Z

Retrying failed(or canceled) jobs...

mssonicbld · 2026-06-29T06:34:49Z

Retrying failed(or canceled) stages in build 1149409:

✅Stage Test:

Job impacted-area-kvmtest-t1-lag-vpp by Elastictest: retried.

auspham · 2026-07-08T06:05:47Z

/azpw retry

mssonicbld · 2026-07-08T06:05:49Z

Retrying failed(or canceled) jobs...

mssonicbld · 2026-07-08T06:05:52Z

No failed(or canceled) stages or jobs found in the most recent build 1149409.

yijingyan2 · 2026-07-14T06:07:18Z

/azp run

azure-pipelines · 2026-07-14T06:07:33Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>

feat: add pynng support for docker-ptf

1f33d07

Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>

Copilot AI review requested due to automatic review settings June 9, 2026 07:13

auspham requested a review from lguohan as a code owner June 9, 2026 07:13

auspham force-pushed the austinpham/38213269-add-pynng-support-for-docker-ptf branch from c28428d to 1f33d07 Compare June 9, 2026 07:13

Copilot started reviewing on behalf of auspham June 9, 2026 07:14 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

auspham closed this Jun 15, 2026

auspham reopened this Jun 15, 2026

auspham closed this Jun 26, 2026

auspham reopened this Jun 26, 2026

yijingyan2 approved these changes Jul 15, 2026

View reviewed changes

yijingyan2 merged commit 30e4d69 into sonic-net:master Jul 15, 2026
37 checks passed

younghuang-CLS pushed a commit to younghuang-CLS/sonic-buildimage that referenced this pull request Jul 15, 2026

feat: add pynng support for docker-ptf (sonic-net#27777)

945bbea

Signed-off-by: Austin (Ngoc Thang) Pham <austinpham@microsoft.com>

Uh oh!

Conversation

auspham commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

Uh oh!

mssonicbld commented Jun 9, 2026

Uh oh!

azure-pipelines Bot commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mssonicbld commented Jun 15, 2026

Uh oh!

azure-pipelines Bot commented Jun 15, 2026

Uh oh!

weiguo-nvidia commented Jun 23, 2026

Uh oh!

auspham commented Jun 26, 2026

Uh oh!

mssonicbld commented Jun 26, 2026

Uh oh!

mssonicbld commented Jun 26, 2026

Uh oh!

auspham commented Jun 26, 2026

Uh oh!

mssonicbld commented Jun 26, 2026

Uh oh!

azure-pipelines Bot commented Jun 26, 2026

Uh oh!

auspham commented Jun 29, 2026

Uh oh!

mssonicbld commented Jun 29, 2026

Uh oh!

mssonicbld commented Jun 29, 2026

Uh oh!

auspham commented Jun 29, 2026

Uh oh!

mssonicbld commented Jun 29, 2026

Uh oh!

mssonicbld commented Jun 29, 2026

Uh oh!

auspham commented Jul 8, 2026

Uh oh!

mssonicbld commented Jul 8, 2026

Uh oh!

mssonicbld commented Jul 8, 2026

Uh oh!

yijingyan2 commented Jul 14, 2026

Uh oh!

azure-pipelines Bot commented Jul 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

auspham commented Jun 9, 2026 •

edited

Loading