fix(blocksync): fix deadlock in AddBlock caused by holding pool.mtx during sendError - #2
Closed
songgaoye wants to merge 1 commit into
Closed
fix(blocksync): fix deadlock in AddBlock caused by holding pool.mtx during sendError#2songgaoye wants to merge 1 commit into
songgaoye wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI failure at: https://github.com/cometbft/cometbft/actions/runs/27214146296/job/80350996164
AddBlockheldpool.mtxvia a deferredUnlockwhile callingsendErroron an unbuffered channel. Any concurrent caller that also neededpool.mtxwould deadlock until the channel was drained.sendErrand dispatching it inside thedeferafter the mutex is released.pool.Height()(which acquirespool.mtx) can proceed whileAddBlockis blocked insendError.PR checklist
CHANGELOG.mddocs/orspec/) and code comments