feat(abci/server): accept pre-bound listener in socket and gRPC servers - #1
Closed
songgaoye wants to merge 1 commit into
Closed
feat(abci/server): accept pre-bound listener in socket and gRPC servers#1songgaoye wants to merge 1 commit into
songgaoye wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewSocketServerWithListenerandNewGRPCServerWithListenerconstructors to the ABCI socket and gRPC servers, following the same convention asnet/http.Serveandgrpc.Server.ServeOnStartskipsnet.Listenwhen a listener is already set, so both constructors share the same start pathMotivation
The existing constructors always call
net.ListeninsideOnStart, which has two drawbacks:net.Listen("tcp", "127.0.0.1:0")the OS assigns an ephemeral port, and the caller knows the exact address before the server starts.Socket-activated processes (e.g. systemd) also rely on passing pre-bound file descriptors, which this enables.
Test plan
TestNewSocketServerWithListener: binds an ephemeral port, starts the server via the new constructor, dials it, stops cleanlyTestNewGRPCServerWithListener: same pattern for the gRPC server