fix(azure): analyze repos with no default branch instead of panicking

[fabio-gos-sonarsource]

Problem

A large Azure DevOps org scan crashes partway through branch identification with:

panic: runtime error: invalid memory address or nil pointer dereference
Analysis failed: exit status 2

The analysis dies mid-run (e.g. at repo 432/522), even though the offending repository looks accessible and valid in the Azure DevOps UI.

Root cause

In the Azure DevOps Go API, git.GitRepository.DefaultBranch (as well as Name and Size) is a *string tagged omitempty, so GetRepository can legitimately return it as nil — typically for a disabled/archived repository, or one whose HEAD ref was never initialized (yet still has branches, so it passes the empty-repo check).

getMostImportantBranch dereferenced *repo.DefaultBranch unconditionally:

defaultBranch = *repo.DefaultBranch   // 💥 panic when DefaultBranch == nil

Because the run was in default-branch mode, that one repo took down the entire scan. There were two further unguarded derefs of these omitempty pointers (getRepoAnalyse error fallback, and *repo.Size).

Fix

Rather than skip a repo with no default branch, this routes it through the branch-scanning engine the tool already has (handleNonDefaultBranch), which picks the most active branch.

• Add defaultBranchName helper for nil-safe default-branch extraction (strips refs/heads/).
• getMostImportantBranch: when a repo has no default branch, fall back to scanning every branch and picking the most active one — so the repo is still analyzed, not dropped or crashed on.
• Harden handleNonDefaultBranch: skip nil branch names, and keep a first-branch fallback so a repo with no recent commits and no default branch still resolves to a real branch instead of an empty string.
• Guard the getRepoAnalyse error fallback and the *repo.Size dereference.
• Add TestDefaultBranchName.

Behavior

For a disabled/archived-style repo with a nil DefaultBranch:

• Before: panic → whole run dies at exit status 2.
• After: picks the largest/most-active branch and continues analyzing all repos.

Testing

• go build ./... ✅
• go test ./pkg/devops/getazure/ ✅ (incl. new TestDefaultBranchName)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gitar-bot]

Code Review ✅ Approved 1 resolved / 1 findings

Adds nil-safe handling for Azure DevOps repositories with missing default branches, preventing panics and ensuring analysis completion. The stale documentation in the fakeGitClient was also corrected.

✅ 1 resolved

✅ Quality: fakeGitClient doc comment says "three calls" but overrides five

📄 pkg/devops/getazure/getazure_test.go:18-32
The comment states the fake "only overrides the three calls exercised by the branch-resolution logic," but the struct actually overrides five methods: GetRepository, GetRepositories, GetItems, GetBranches, and GetCommits. This is a harmless but misleading doc string that could confuse future maintainers about which calls are stubbed. Suggest updating the count (or making it generic, e.g. "only overrides the calls exercised by the branch-resolution and repo-analysis logic").

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}