Slovak translation (draft, for review) - #8
Draft
somansch wants to merge 1 commit into
Draft
Conversation
Both halves of it: the integration's own sk.json and the sk block in the dashboard card, which carries its own copy of every language and falls back to English without one. The 114 strings @petersoniq submitted in #7 are kept word for word - the upload was cut off at 44% of the file, so the remaining 143 are filled in here, along with all 459 of the card's. Checked mechanically only: key parity with English in both files (257 and 459, none missing or extra), every placeholder present and identical, and the card still parsing with the block inserted. The Slovak itself is unreviewed and is what this branch is asking for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slovak, both halves of it, as a draft for @petersoniq to correct. Closes #7 once it is reviewed.
What is in here
custom_components/annuals/translations/sk.jsoncustom_components/annuals/frontend/annuals-card.jsskblock, sosk.jsonon its own would have given you a Slovak dialog and an English card.What has been checked, and what has not
Verified mechanically: both files have exactly the same keys as English (257 and 459, none missing, none extra), every
{placeholder}is present and identical, the long descriptions keep their line structure, and the card still parses with the block inserted.Not verified: whether it is good Slovak. That is the entire point of this branch.
Three keys in the card are code rather than text, and are not literal translations:
The timeline sentence follows the Czech one and uses a dash instead of a verb —
{possessive}: {ordinal}{sup} {type} — {when}— which sidesteps the case and gender agreement a literal "is" would need. Say so if a Slovak reader would phrase it differently.One thing to decide
Your strings use two words for the product: the title is „Výročia", the hub is „Centrum Ročenky", and VIP annual became „VIP ročenka". Your wording is untouched, and the new strings follow whichever you had used nearby — but it should be one or the other, and it is your call.
What to do
Open the Files changed tab above. On any line that reads translated rather than written:
+, then use the ± button in the comment box to write a suggestion. That puts your wording in as a proposed change, and it goes in with one click from here. This is the easiest way and needs nothing installed.sk.jsonand thesk:block, and open a pull request against this branch (sk-translation).No rush, and no need to go through all 716 strings if only some read wrong — anything you leave uncommented I will take as acceptable. Nothing ships until you have had a look.
Thanks for starting this off.