Add community right-click menu, collapsible tooltip sections, and usa… - #54
Open
sberhorst wants to merge 3 commits into
Open
Add community right-click menu, collapsible tooltip sections, and usa…#54sberhorst wants to merge 3 commits into
sberhorst wants to merge 3 commits into
Conversation
…ge hint Reworks tooltip/config locale strings and adds community right-click support alongside existing guild right-click actions.
Author
Summary of changesNew feature: Battle.net Community support
TWW (12.x) compatibility fixes
Bug fixes
UX improvements
Cleanup
Open question for reviewers
|
Author
|
This PR is ready for review whenever you have a chance — all checks are passing (GitGuardian clean) and there are no merge conflicts with master. Let me know if you'd like any changes before merging. Thanks! |
added 2 commits
June 30, 2026 14:41
…allback - Pre-subscribe to each community's presence via C_Club.SetClubPresenceSubscription() on addon load so Blizzard pushes full member data before the user first opens the Communities panel. Resolves members rendering as "Unknown" on the first tooltip open after login. - Wire up the previously-unused L.TOOLTIP_COMMUNITY locale string as the fallback club name in renderCommunities(), resolving the open reviewer question noted in the PR summary comment.
…OMMUNITY - Pre-subscribe to each community's presence via C_Club.SetClubPresenceSubscription() on addon load so Blizzard pushes full member data before the first tooltip open after login. Resolves community members rendering as "Unknown" on the first hover. - Detect guild rank promotions and demotions via locale-safe pattern matches against ERR_GUILD_PROMOTE_SSS / ERR_GUILD_DEMOTE_SSS system messages and force a fresh C_GuildInfo.GuildRoster() request, so rank changes reflect in the tooltip immediately without a UI reload. - Wire the previously-unused L.TOOLTIP_COMMUNITY locale string as the fallback club name in renderCommunities(), resolving the open reviewer question noted in the PR summary comment.
solocommand
reviewed
Jul 1, 2026
solocommand
left a comment
Owner
There was a problem hiding this comment.
Thanks for contributing!
These changes all look fine, but I'm unable to verify the Communities feature. When I load your changes, I see the configuration for communities, but I don't see them displayed in the tooltip. Is this verified working for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ge hint
Reworks tooltip/config locale strings and adds community right-click support alongside existing guild right-click actions.