chore(mas): pin masDev identity to Apple Development cert SHA-1 - #778
chore(mas): pin masDev identity to Apple Development cert SHA-1#778mrangelmarino wants to merge 1 commit into
Conversation
Pins masDev.identity from the bare string "Apple Development" to the SHA-1 fingerprint (5106DA8B43E1AF25E3B553CABD91400445A9E68A) of the existing valid Apple Development cert under team 8PT2Y7QQ2F (valid through 2027-03-18). Bare string already resolves to the one valid cert on this keychain, so this is defensive hygiene — removes ambiguity in case a second Apple Development cert is later added. Cannot be verified until provisioning steps are completed (register Mac UDID 00006040-0004482A0187801C under 8PT2Y7QQ2F and regenerate build/Prose_Development.provisionprofile). Refs #487 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
/review Auto-triggered after E2E tests passed. |
Code ReviewElectron Security Checklist
Change: Correctness: Sound. One minor note: The cert expires 2027-03-18. When it rotates, this fingerprint will silently cause signing to fail on that target until updated. Not a blocker, but consider a comment like No bugs, security issues, or other concerns with the change itself. |
✅ Ready to MergeCode review found no significant issues. This PR is ready for human approval and merge. |
Summary
Pins
masDev.identityfrom the bare stringApple Developmentto the SHA-1 fingerprint of the existing valid Apple Development cert for the MAS team8PT2Y7QQ2F:(Cert:
CN=Apple Development: ANGEL MARINO (2Y3M2V2Q5F),OU=8PT2Y7QQ2F, valid through 2027-03-18)The bare
Apple Developmentstring already resolves to this cert on the current keychain — this is defensive hygiene to remove ambiguity if a second Apple Development cert is ever added.Why this is not the fix for error 163
The root cause of error 163 is a missing or stale
build/Prose_Development.provisionprofile— the profile must embed:8PT2Y7QQ2FApple Development cert (SHA-1 above)00006040-0004482A0187801C)8PT2Y7QQ2F.ist.solo.prose)Until those provisioning steps are done, rebuilding with this pin will still yield error 163.
Pending human steps (before this PR can be merged and verified)
8PT2Y7QQ2Fin the Apple Developer portal:00006040-0004482A0187801Cbuild/Prose_Development.provisionprofileforist.solo.proseunder8PT2Y7QQ2F, embedding:5106DA8B43E1AF25E3B553CABD91400445A9E68A)8PT2Y7QQ2F.ist.solo.prosebuild/Prose_Development.provisionprofilenpx electron-builder --mac mas-devand verify the app launches without error 163.Refs #487