Skip to content

Fix typos - #539

Open
deining wants to merge 2 commits into
solo-io:mainfrom
deining:fix-typos
Open

Fix typos#539
deining wants to merge 2 commits into
solo-io:mainfrom
deining:fix-typos

Conversation

@deining

@deining deining commented Nov 17, 2024

Copy link
Copy Markdown

This PR fixes various typos I spotted in the project.
BOT NOTES:
resolves #539

@solo-build-bot

Copy link
Copy Markdown

Waiting for approval from someone in the solo-io org to start testing.

ashleywang1
ashleywang1 previously approved these changes Dec 3, 2024

@ashleywang1 ashleywang1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixes are all valid, and hopefully the changelog bot passes

@jsoref

jsoref commented Sep 3, 2025

Copy link
Copy Markdown

@ashleywang1 was someone going to merge this PR? (asking because I was considering making a PR, ...)

@solo-changelog-bot

Copy link
Copy Markdown

Issues linked to changelog:
#539

@deining

deining commented Sep 3, 2025

Copy link
Copy Markdown
Author

Just rebased my PR.
Also added a changelog file, checker is green now 😄.
Hopefully this PR can be now merged soon!

@deining

deining commented Sep 3, 2025

Copy link
Copy Markdown
Author

/test

Test run is failing, however that's most likely not introduced by the changes in my PR.

@ashleywang1: can you step in, please?

@jsoref jsoref mentioned this pull request Oct 23, 2025
@jsoref

jsoref commented Oct 24, 2025

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants