Skip to content

fix(ec2): add error logging for credential failures in EC2 discovery #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wkrause13 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(ec2): add error logging for credential failures in EC2 discovery #11117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/v1.21.0-beta14/ec2-credential-error-logging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
changelog:
- type: FIX
issueLink: https://github.com/solo-io/gloo/issues/0000
resolvesIssue: false
description: Add ERROR level logging when EC2 upstream discovery fails due to invalid or missing AWS credentials.
2 changes: 2 additions & 0 deletions projects/gloo/pkg/plugins/aws/ec2/eds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ func (c *edsWatcher) updateEndpointsList(endpointsChan chan v1.EndpointList, err
for _, ns := range c.secretNamespaces {
nsSecrets, err := c.secretClient.List(ns, clients.ListOpts{Ctx: c.watchContext})
if err != nil {
contextutils.LoggerFrom(c.watchContext).Errorw("failed to list secrets for EC2 upstream discovery", "namespace", ns, "error", err)
errs <- err
return
}
Expand All @@ -100,6 +101,7 @@ func (c *edsWatcher) updateEndpointsList(endpointsChan chan v1.EndpointList, err

allEndpoints, err := getLatestEndpoints(c.watchContext, c.ec2InstanceLister, secrets, c.writeNamespace, c.upstreams)
if err != nil {
contextutils.LoggerFrom(c.watchContext).Errorw("failed to fetch EC2 instances for upstream discovery", "error", err)
errs <- err
return
}
Expand Down