upgrade envoy to v1.36.7 - #498
Merged
soloio-bulldozer[bot] merged 3 commits intoJun 4, 2026
Merged
Conversation
|
Issues linked to changelog: |
puertomontt
approved these changes
Jun 4, 2026
nfuden
reviewed
Jun 5, 2026
| def envoy_gloo_dependencies(): | ||
| _repository_impl("envoy", patches=[ | ||
| _repository_impl("envoy", | ||
| patch_args = ["-p1"], |
Collaborator
Author
There was a problem hiding this comment.
I had no preference on this but seems that everyone else is generating patches with prefix, istio, envoy ...etc so this is to be consistent so when copying patches around, people just use their normal workflow instead of finding out later the patch doesn't apply.
We should chat about this when we meet in person on why p1 is bad ...lol.
There was a problem hiding this comment.
It was purely due to problems when double wrapping that would take place in enterprise
Collaborator
Author
There was a problem hiding this comment.
You mean the patch of patch which I called inception style patch. Glad they are no more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.