Skip to content

Removed unused lambda function - #68

Merged
jerrytfleung merged 9 commits into
swofrom
remove_unused
Apr 15, 2026
Merged

Removed unused lambda function#68
jerrytfleung merged 9 commits into
swofrom
remove_unused

Conversation

@jerrytfleung

@jerrytfleung jerrytfleung commented Apr 15, 2026

Copy link
Copy Markdown
  1. Removed unnecessary lambda functions (java, nodejs, python, ruby, go...) and directories to reduce the scope of vulnerability checks.
  2. Updated codeQL to check the go code under collector directory.

https://swicloud.atlassian.net/browse/NH-135273

@jerrytfleung
jerrytfleung marked this pull request as ready for review April 15, 2026 21:50
@jerrytfleung
jerrytfleung requested review from a team and Copilot April 15, 2026 21:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR significantly reduces repository scope by removing multiple language-specific layers, sample applications, and related CI/release infrastructure, while narrowing CodeQL scanning to the Go code under collector/.

Changes:

  • Remove language-specific layer implementations, sample apps, and supporting tooling (Terraform/SAM/CloudFormation/scripts) across the repo.
  • Update CodeQL workflow configuration to target only the collector directory.
  • Update README/docs to remove/alter references to removed content.

Reviewed changes

Copilot reviewed 161 out of 167 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.github/workflows/codeql.yml Restricts CodeQL target matrix to collector (but currently misses required steps to publish results).
collector/README.md Removes links to contribution/setup artifacts that were deleted, leaving non-actionable “here/Contributing” references.
README.md Removes language support section and replaces the design proposal link with unlinked text.
.github/dependabot.yml Removes Dependabot update configuration for deleted subprojects, keeping collector-related updates.
utils/terraform/api-gateway-proxy/* (removed) Removes Terraform module previously used by sample deployments.
utils/sam/run.sh (removed) Removes SAM deployment helper script.
utils/aws-cloudformation/aws-cf-stack-for-layer-publish.yml (removed) Removes CloudFormation template referenced by collector publishing docs.
python/** (removed) Removes Python layer implementation, tests, sample apps, and CI/release support.
ruby/** (removed) Removes Ruby layer implementation, sample apps, and CI/release support.
nodejs/** (removed) Removes NodeJS layer implementation, sample apps, tests, and CI/release support.
java/** (removed) Removes Java layers, sample apps, Gradle build, and CI/release support.
go/sample-apps/** (removed) Removes Go sample applications and deployment assets.
dotnet/** (removed) Removes .NET sample app and documentation.
.github/workflows/ci-*.yml (removed) Removes language/tooling-specific CI workflows (python/nodejs/java/terraform/shellcheck).
.github/workflows/release-layer-*.yml (removed) Removes release workflows for non-collector layers (python/nodejs/ruby/java).
docs/design_proposal.md (removed) Removes design proposal doc previously linked from root README.
CONTRIBUTING.md (removed) Removes repository-level contributing guide.
Files not reviewed (1)
  • nodejs/sample-apps/aws-sdk/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread collector/README.md Outdated
Comment on lines 65 to 66
To setup those, you can use (copy or load) the AWS CloudFormation template here.
Once AWS CloudFormation stack is created from the given template,

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mentions using a CloudFormation template “here”, but the template file under utils/aws-cloudformation/ was deleted in this PR and there’s no replacement link. Please either restore/include the template (or equivalent instructions) or link to a new canonical location so users can actually set up the required OIDC/IAM resources.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this one too

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the cloudformation layer publish section as we used GHA to publish collector lambda layers

Comment on lines 87 to 89
# - run: |
# echo "Run, Build Application using script"
# ./location_of_script_within_repo/buildscript.sh

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodeQL job currently doesn't run github/codeql-action/analyze, so no results will be uploaded to code scanning. Also, the build step needs to run inside the collector directory (or set CodeQL source-root) since the repo root has no go.mod—otherwise Autobuild is likely to fail. Please add the Analyze step and ensure the build/source root is correctly set for the matrix directory.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/codeql.yml
Comment thread README.md
Comment thread collector/README.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread docs/design_proposal.md Outdated

@tammy-baylis-swi tammy-baylis-swi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm and makes sense if we don't build nor test with these.

I had one question and agree with Copilot recommendations.

@jerrytfleung
jerrytfleung merged commit 7f2f6df into swo Apr 15, 2026
4 checks passed
@jerrytfleung
jerrytfleung deleted the remove_unused branch April 15, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants