This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Conversation
ronilan
force-pushed
the
nh-main
branch
3 times, most recently
from
April 13, 2022 04:32
2026e18 to
753e59b
Compare
ronilan
force-pushed
the
nh-main
branch
4 times, most recently
from
April 27, 2022 20:57
b9ac49d to
79efd90
Compare
…ting trace context processing mode (0 = xtrace; 1 = w3c, default = 0).
…odification approach. no refactoring. - init options include mode and options updated to version 13. - Event::makeFromBuffer accepts either xtrace or traceparent input and acts accordingly. - getTraceSettings accepts either xtrace or traceparent input and acts accordingly. - getTraceSettings accepts a tracestate as input and passes to oboe tracing decision method. input updated to version 3. - javascript Event.makeFromString (wrapper to Event::makeFromBuffer) accepts either xtrace or traceparent input and acts accordingly. - adapted Event.toString functionality can generate various formatted outputs when in mode 1.
…n both mode 1 and mode 0.
1. Removed all hard coded urls. 2. Use use new standard public environment variables SW_APM_SERVICE_KEY, SW_APM_COLLECTOR to set which servers test run against in mode 1. 3. Added SW_TEST_PROD_SERVICE_KEY environment variable to cover the specific test case of initialization without url in mode 1. 4. Additional tweaks to make mode 0 and mode 1 similar.
…ing and release bucket locations. Updated Docs accordingly.
…ne 3.15 and above.
…es introduced in liboboe 10.4.0 and above.
…ved version is available in the agent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*** DRAFT *** FOR REVIEW ONLY *** DO NOT MERGE *** DRAFT ***
Overview
This pull request provides the bindings with the functionality required in order to work with liboboe 10.3.x+.
Implementation is using minimal modification approach. No refactoring has been done.
Core Changes
Enabled support for liboboe mode 1 (w3c) in bindings (0c62e4f)
- init options include mode and options updated to version 13.
-
Event::makeFromBufferaccepts eitherxtraceortraceparentinput and acts accordingly.-
getTraceSettings acceptseitherxtraceortraceparentinput and acts accordingly.-
getTraceSettingsaccepts atracestateas input and passes to oboe tracing decision method.- javascript
Event.makeFromString(wrapper toEvent::makeFromBuffer) accepts eitherxtraceortraceparentinput.-
Event.toStringfunctionality can generate various formatted outputs in both mode 0 and mode 1.Tightened regex validation of
xtraceandtraceparent(6a345ac)Updated logic used to decide if a trace has metadata due to api changes introduced in liboboe
10.4.0and above (617e319)Additional changes:
Other Changes
Notes:
10.2.x).https://github.com/appoptics/appoptics-apm-node/tree/nh-main