Modernize record actions into plugin instruction plans#336
Merged
Conversation
This PR replaces record's hand-written `actions.ts` helpers with instruction-plan getters wired into `splRecordProgram()` under `client.splRecord.instructions.*`, matching the Kit-plugin convention used across the other Solana program clients. It adds a chunked `getWriteInstructionPlan` that splits a write of any length across multiple transactions, exposes the record payload via a new `payload` field on the `RecordData` account in the IDL, and restructures the tests into one focused file per instruction (to mirror other repos).
Member
Author
|
@joncinque I know this is mainly a JS client change but I wanted your approval since it touches a little bit on the IDL and it refactors quite a lot of JS tests. |
joncinque
approved these changes
Jun 8, 2026
joncinque
left a comment
Contributor
There was a problem hiding this comment.
This looks great!
Sorry, I had to read up a bit on Typescript fundamentals to understand the plugin definition and creation, but after that, all smooth sailing 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces record's hand-written
actions.tshelpers with instruction-plan getters wired intosplRecordProgram()underclient.splRecord.instructions.*, matching the Kit-plugin convention used across the other Solana program clients. It adds a chunkedgetWriteInstructionPlanthat splits a write of any length across multiple transactions, exposes the record payload via a newpayloadfield on theRecordDataaccount in the IDL, and restructures the tests into one focused file per instruction (to mirror other repos).