fix(seed-vault-rn): observer crash on API 24-29 and listener leak - #772
Open
Michaelembiring wants to merge 1 commit into
Open
fix(seed-vault-rn): observer crash on API 24-29 and listener leak#772Michaelembiring wants to merge 1 commit into
Michaelembiring wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
androidmodule of@solana-mobile/seed-vault-libdeclaresminSdkVersion 24, making all three legacyContentObserver.onChangeoverloads reachable on API 24–29 devices.onChangeoverloads wereTODO()calls that threwNotImplementedErrorwhenever the platform invoked them instead of the API 30+Collection<Uri>variant.registerForActivityResultattached anonymous listeners toreactContextwith no removal mechanism on timeout, completion, or module teardown.Solution
onChangeoverloads delegate todispatchContentChange(uris). Legacy callbacks carrying no URI fall back tolistOf(WalletContractV1.WALLET_PROVIDER_CONTENT_URI_BASE).mPendingListeners(ConcurrentHashMap) and removed exactly once via a per-listenerAtomicBoolean(settled).cleanupResources()unregisters the observer and clears pending listeners. Guarded by anAtomicBoolean(cleanedUp) and wired to bothinvalidate()andonCatalystInstanceDestroy().Verification
SolanaMobileSeedVaultLibModule.kt..classbytecode artifacts without errors.