refactor: make authorizationCache, chainSelector and onWalletNotFound in registerMwa optional - #1271
refactor: make authorizationCache, chainSelector and onWalletNotFound in registerMwa optional#1271beeman wants to merge 1 commit into
Conversation
|
CI build is failing on these changes @beeman |
|
closed, inactive. feel free to reopen |
… in registerMwa optional
1a87422 to
ffd4bc4
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthrough
ChangesWallet configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change makes three registerMwa options optional while providing defaults that preserve existing behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This commit makes the
authorizationCache,chainSelectorandonWalletNotFoundproperties ofregisterMwaoptional.It does so by extracting the
LocalSolanaMobileWalletAdapterWalletOptionsinto an object, marking the properties as optional and haveRemoteSolanaMobileWalletAdapterWalletOptionsextend it.After that, we provide a default value in the constructor so that this function remains working the same, it just needs a few less parameters to set up.
Summary by CodeRabbit