feat(rpc): support multiple API keys - #663
Open
raushan728 wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryAdds support for multiple configured API keys while retaining backward-compatible deserialization of the legacy single-key setting.
Confidence Score: 5/5The PR appears safe to merge, with the previous timing concern addressed and no new actionable failures identified. API-key authentication now hashes both sides to fixed-size digests, checks every configured key without early exit, and retains correct matching behavior for keys of different lengths. No repository-rule violations or outstanding previous findings remain. Important Files Changed
Reviews (2): Last reviewed commit: "feat(rpc): support multiple API keys wit..." | Re-trigger Greptile |
raushan728
force-pushed
the
feat/multi-api-keys
branch
from
September 5, 2026 13:26
e72b08e to
6aad9a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
api_key: Option<String>toapi_keys: Option<Vec<String>>, with backward-compatible deserialization for existing single-key configs (with a deprecation warning). Compares keys via fixed-length SHA-256 hashes with constant-time comparison across all configured keys, avoiding any length-dependent timing signal, and stores a key index as the client identity.Note: this is a split-out of #559.