Skip to content

Minor Changes#5

Open
greg42 wants to merge 16 commits into
sol:masterfrom
greg42:master
Open

Minor Changes#5
greg42 wants to merge 16 commits into
sol:masterfrom
greg42:master

Conversation

@greg42

@greg42 greg42 commented Oct 4, 2013

Copy link
Copy Markdown

I've added some minor things. Maybe you'd like to have a look at my changes :)

@sol

sol commented Oct 5, 2013

Copy link
Copy Markdown
Owner

@greg42 Hey, I pushed " FreeBSD support", "Updated documentation" and "Make bash completion script more portable" to master (you may want to rebase ;).

"Allow passing parameters to GPG" looks useful, too. Can you make sure that the tests pass + add corresponding tests to test/OptionsSpec.hs (see the corresponding section of the, that I just added)? And a more descriptive option name would be cool. What about --gpg-option? We can keep -g as a shortcut, if you want it. I don't care, as with completion --gpg-option is almost as fast to type.

@greg42

greg42 commented Oct 6, 2013

Copy link
Copy Markdown
Author

That should (hopefully) fix the test suite. I'll add tests for my new features soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants