Cubrid histogram - #25
Conversation
:빌드 되게 만들고 나머지 TODO 및 ASSERT 처리
- 중간부 구현: SERVER_SIDE로 가기 직전의 빌드 가능하고, 실행 가능한 상태로 중간 구현
- histogram 관련 오류 수정 (db_class fetch 방법 관련)
…/cubrid into CBRD-26217-histogram # 제목: 변경 요약 (50자 이내) (refactor, hotfix, feature) # 본문: 변경 사항에 대한 자세한 설명 # - 주요 변경 사항 1 # - 주요 변경 사항 2 # 참고: 이 라인 아래의 내용은 커밋 메시지에서 제거됩니다.
class 전체의 meta 정보가 histogram에 포함되지 않도록 변경
# 제목: 변경 요약 (50자 이내) (refactor, hotfix, feature) # 본문: 변경 사항에 대한 자세한 설명 # - 주요 변경 사항 1 # - 주요 변경 사항 2 # 참고: 이 라인 아래의 내용은 커밋 메시지에서 제거됩니다.
# 제목: 변경 요약 (50자 이내) (refactor, hotfix, feature) # 본문: 변경 사항에 대한 자세한 설명 # - 주요 변경 사항 1 # - 주요 변경 사항 2 # 참고: 이 라인 아래의 내용은 커밋 메시지에서 제거됩니다.
|
@codex 리뷰 해봐 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 9 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 229e6c9569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
http://jira.cubrid.org/browse/CBRD-XXXX
Purpose
N/A
Implementation
N/A
Remarks
N/A
Note
High Risk
High risk because it introduces new system catalog objects and new DDL (
ANALYZE ... UPDATE/DROP HISTOGRAM) while also changing query selectivity estimation in the optimizer based on stored histograms.Overview
Adds persistent column histograms backed by a new system catalog table/view (
_db_histogram/db_histogram) plus a newsrc/histogrammodule to build, store, read, and dump histogram blobs (including null-frequency).Extends the SQL layer to support
ANALYZE TABLE ... UPDATE HISTOGRAM ... WITH <n> BUCKETS [WITH FULLSCAN]andANALYZE TABLE ... DROP HISTOGRAM ..., wires execution intoexecute_schema.c, and updates DDL logging/statement types/CSQL output.Integrates histogram data into planning by caching histograms on
SM_CLASSand using them inquery_planner.cto compute=/</<=/>/>=andBETWEENselectivities (falling back to defaults when unavailable), along with related object/template and unique-key lookup refactors needed for catalog access.Written by Cursor Bugbot for commit 229e6c9. Configure here.