Skip to content

Launcher based on JSON Configuration and CIMpy - #259

Closed
martinmoraga wants to merge 94 commits into
masterfrom
ba-can
Closed

Launcher based on JSON Configuration and CIMpy#259
martinmoraga wants to merge 94 commits into
masterfrom
ba-can

Conversation

@martinmoraga

@martinmoraga martinmoraga commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

This PR implements:

  • CIM2DPsim: new cim Reader based on cimpy
  • DPsim2CIM: new converter dpsim to cimpy based on cimpy
  • DPsimLauncher

Based on #243 and on this PR of cimpy

Martin Moraga and others added 30 commits October 19, 2023 11:03
Martin Moraga
add PSS type 2 and add base class for exciter
ca2329b 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add PSS and Govenor to dpsimpy
9760512 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add exciter DC1
ced82f0 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
rename PSS Type 2 -> PSS1A
e3f6490 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add docu of SG controllers
927071c 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
resolve rebase conflicts
96fdec7 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add PSS to validation notebook
9ea7d6b 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
fix some errors
74eaecd 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
remove parameter dt from setParameters() of PSS
4e60c63 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add simplified exciter model ST1
c975436 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
new class structure exciterParameters
c3e25a5 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@Gleb4x Martin Moraga
added new Hydro and Steam Turbines and Governor models
88891c7 
Signed-off-by: Glebs Ogorodniks <glebs.ogorodniks@rwth-aachen.de>
Martin Moraga
added new base class for Governors
9a8b834 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add base class for PSS
bc2fe5e 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
delete duplicated examples (they are implemented using dpsimpy)
8a628da 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
new base class for Turbine
d3be0ff 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@Gleb4x Martin Moraga
Update documentation with Hydro and Steam plants
ca1c77c 
Hydro/Steam Turbine and Governor documentation hast been added. The pictures will be added after test

Signed-off-by: Glebs Ogorodniks <130448212+Gleb4x@users.noreply.github.com>
Martin Moraga
refactor steam & hydro turbine/governors to support new class structure
343e5d3 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add images for docs
4c84d35 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
remove one-step delay in emt VoltageSource
fbb67be 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
log initial values of attributes
b71be4c 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
adapt step function to compute first simulation step at t=timestep
5711ba2 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
solve errors of last commit
1e2ad6e 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
fix initialization error in EMT_Ph3_Transformer
6e9fc40 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
resolve rebase errors
69ee2c9 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
change simulation timec riteria to stop simulation
849c82c 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
solve errors of last commit
485ad8f 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@m-mirz Martin Moraga
implement RL node reduced equations
780d17e 
Signed-off-by: Markus Mirz <mmirz@eonerc.rwth-aachen.de>
Martin Moraga
fix errors of last commit
6352f6d 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add validation notebook for rl-element
8d09dd3 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga and others added 16 commits October 20, 2023 08:38
Martin Moraga
small change in function setParameters of Loads
1332c0a 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
fix some errors in matpower reader
0fcc8ef 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
fix small error in initialization of EMT_Ph3_SeriesSwitch.cpp
40bc787 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
fix small error in SP & DP PiLines
32b19ce 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
add MatDyn examples
669c2f3 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
Martin Moraga
solve rebase conflicts
83905e7 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@Gleb4x Martin Moraga
fix some errors
169f583 
Signed-off-by: Glebs Ogorodniks <glebs.ogorodniks@rwth-aachen.de>
Martin Moraga
fix small errors in matpower reader
e87d4a5 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@Canfirat98 Martin Moraga
added cim2dpsim
be78148 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
added dpsim2cim
327681f 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
added dpsimlauncher
9dc569e 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
add json files
a35418c 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
added jupyter notebooks for dpsim launcher
9be7a6f 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
change some SG parameters to attributes
3a51551 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
add some functions to dpsimpy
ab47de3 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
add dpsimLauncher examples
8d3f297 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@Canfirat98 Martin Moraga
fix some errors
45fa65f 
Signed-off-by: Canfirat98 <can.yaruk@rwth-aachen.de>
@martinmoraga martinmoraga self-assigned this Oct 26, 2023
@martinmoraga martinmoraga added the enhancement New feature or request label Oct 26, 2023
Martin Moraga
resolve rebase errors
8bec7ef 
Signed-off-by: Martin Moraga <martin.moraga@eonerc.rwth-aachen.de>
@sonarqubecloud

sonarqubecloud Bot commented Oct 26, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 255 Code Smells

0.0% 0.0% Coverage
13.6% 13.6% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dinkelbachjan dinkelbachjan changed the title Ba can DPsim Launcher based on JSON Configuration and CIMpy Oct 26, 2023
@dinkelbachjan dinkelbachjan changed the title DPsim Launcher based on JSON Configuration and CIMpy Launcher based on JSON Configuration and CIMpy Oct 26, 2023
@stv0g

stv0g commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Cool @martinmoraga,

cant wait for this to land! Do want to wait until #243 is merged? Or can we rebase the launcher changes onto master and merge them separately?

@martinmoraga

martinmoraga commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

Cool @martinmoraga,

cant wait for this to land! Do want to wait until #243 is merged? Or can we rebase the launcher changes onto master and merge them separately?

@stv0g
I think we should wait, since I don't know if everything will work well...

@stv0g

stv0g commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

It also seems to me that this PR is based on some other (SG controllers)?

In order to merge this, we would need to isolate the changes (rebase to master) or merge the controllers first.

@stv0g stv0g closed this Nov 13, 2024
@stv0g
stv0g deleted the ba-can branch November 13, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@martinmoraga martinmoraga

Labels

enhancement New feature or request

Projects

DPsim
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@martinmoraga @stv0g @Gleb4x @m-mirz @kalyan1370 @gnakti @Canfirat98