Skip to content

Moderpython simplification + Attribute NS - #21

Merged
m-mirz merged 6 commits into
masterfrom
custom_profiles
Nov 15, 2023
Merged

Moderpython simplification + Attribute NS#21
m-mirz merged 6 commits into
masterfrom
custom_profiles

Conversation

@guillaume-alliander

@guillaume-alliander guillaume-alliander commented Oct 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Mostly split Base.py in a bunch of smaller, more specific classes, and add attributes NS.

@guillaume-alliander
Helpers for custom attributes
0378057 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander
Modernpython: Rationalise non-resource files/modules
d6e174e 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander
make the resource module callable.
02248cd 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander
Remove fun but overkill callable module shortcut
cc8a46d 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander
Fix namespace of attributes after review comment
92a3f8f 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander
Tell Sonar that namespaces are safe
532454a 
Signed-off-by: Guillaume Roger <guillaume.roger@alliander.com>
@guillaume-alliander guillaume-alliander changed the title Custom profiles Moderpython simplification + Attribute NS Oct 20, 2023
@guillaume-alliander
guillaume-alliander marked this pull request as ready for review October 20, 2023 07:44
@guillaume-alliander guillaume-alliander mentioned this pull request Oct 20, 2023
Closed
@m-mirz

m-mirz commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

@guillaume-alliander What is the state of this PR? Can it be merged before #20 or is there some dependency? Please assign this to me when you would like one of us to have a look.

If you would like to discuss the roadmap or maintainer role with us, feel free to reach out to @dinkelbachjan and me via mail or slack.

@guillaume-alliander

guillaume-alliander commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator Author

I would like to have confirmation from @chicco785 but this one should be merged before #20 I believe.

@chicco785

chicco785 commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

I would like to have confirmation from @chicco785 but this one should be merged before #20 I believe.

yes, i will rebase my changes on top of this PR

chicco785
chicco785 approved these changes Nov 14, 2023
View reviewed changes

@chicco785 chicco785 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look, it seems fine to me.

@sonarqubecloud

sonarqubecloud Bot commented Nov 15, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@m-mirz
m-mirz requested review from m-mirz and removed request for m-mirz November 15, 2023 20:38
@m-mirz
m-mirz merged commit 5eb12f8 into master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chicco785 chicco785 chicco785 approved these changes
@m-mirz m-mirz m-mirz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guillaume-alliander @m-mirz @chicco785