Skip to content

Add pagination for list repositories and tags #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mnasiadka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pagination for list repositories and tags #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 37 additions & 12 deletions quaytool/quaytool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,23 @@ def list_repositories(api_url, headers, insecure, organization, visibility):
if organization:
url += "&namespace=%s" % organization

r = requests.get(url, headers=headers, verify=insecure)
r.raise_for_status()
return r.json()
repositories = []
next_page = None
while True:
page_url = "%s&next_page=%s" % (url, next_page) if next_page else url
r = requests.get(page_url, headers=headers, verify=insecure)
r.raise_for_status()
data = r.json()
new_repos = data.get('repositories', [])
# Workaround for Quay API bug: next_page token returning same repos
if all(repo in repositories for repo in new_repos):
break
repositories.extend(new_repos)
next_page = data.get('next_page')
if not next_page:
break

return {'repositories': repositories}


def expire_tag(api_url, headers, insecure, organization, tag, repositories,
Expand Down Expand Up @@ -324,6 +338,22 @@ def _make_restore(api_url, headers, insecure, organization, tag, repository,
r.raise_for_status()


def _get_all_tags(api_url, headers, insecure, organization, repo_name):
tags = []
page = 1
while True:
url = "%s/repository/%s/%s/tag?page=%d" % (
api_url, organization, repo_name, page)
r = requests.get(url, headers=headers, verify=insecure)
r.raise_for_status()
data = r.json()
tags.extend(data.get('tags', []))
if not data.get('has_additional'):
break
page += 1
return tags


def _tag_helper(api_url, headers, insecure, organization, tag, repositories,
days=None, expire_tag=False, restore_tag=False):

Expand All @@ -334,19 +364,14 @@ def _tag_helper(api_url, headers, insecure, organization, tag, repositories,

missing_tags = []
for repository in repositories:
# get all available tags for that repository
url = "%s/repository/%s/%s/tag" % (api_url, organization,
repository['name'])
r = requests.get(url, headers=headers, verify=insecure)
r.raise_for_status()

available_tags = r.json()
available_tags = _get_all_tags(api_url, headers, insecure, organization,
repository['name'])

if 'tags' not in available_tags:
if not available_tags:
print("Can't find any tag for repository %s" % repository['name'])
continue

for available_tag in available_tags['tags']:
for available_tag in available_tags:
if available_tag['name'] == tag:
print("Found a tag %s in repository %s" % (
tag, repository['name']))
Expand Down