chore: drop the stale tokenizers-cpp submodule entry - #1430
Merged
Conversation
.gitmodules still declared a submodule at third-party/tokenizers-cpp, but the tokenizers migration (#781) removed that gitlink. The tree has two submodules, googletest and phonemis, against three config entries. Harmless in practice, since `git submodule update` walks the gitlinks in the index rather than the config, which is why it went unnoticed. It is still misleading to anyone reading the file for what the checkout needs. `git submodule update --init` for both remaining paths still succeeds.
barhanc
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitmodulesdeclares three submodules; the tree has two.third-party/tokenizers-cppthird-party/googletestpackages/react-native-executorch/third-party/common/phonemisThe tokenizers migration (#781) removed the gitlink but left the config entry behind.
Harmless in practice, since
git submodule updatewalks the gitlinks in the index rather than the config, which is why nobody hit it. Still misleading to anyone reading the file to learn what a checkout needs, andcreate-package.shrelies on the phonemis entry being accurate.Verified
git submodule update --initfor both remaining paths still checks out cleanly after the edit.Found while auditing root files for staleness ahead of the 0.10 release. Everything else at the root checked out:
.yarnrc.yml's React 19 peer suppression is still needed (@signalwire/docusaurus-theme-llms-txtis still at1.0.0-alpha.9withreact: ^18.0.0peers), andCONTRIBUTING.md's paths all still exist.