Fix Lua table -> Elixir list mapping - #21
Merged
Merged
Conversation
tom-ehh
requested review from
dimamik
and
a lite review from Copilot
and removed request for
Copilot
August 12, 2026 09:42
dimamik
approved these changes
Aug 12, 2026
dimamik
left a comment
dimamik
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this!
I'm aware that this is not an ideal way of handling this, but it should be relatively fine for now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches decode inconsistency in Lua library.
The decode path for lua tables in the library is:
The issue was that for maps which have >32 key-value pairs are unordered in BEAM, so the heuristic that when keys in the keyword list are sorted natural numbers couldn't hold. This hotfix sorts the keys before running the same approach.