Conversation
cxzhong
marked this pull request as ready for review
August 7, 2026 04:56
|
It got conflicted. |
Author
It should regenerate the |
…-lookup-timeout # Conflicts: # dist/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getReleaseByTagreturns 404dist/index.jsRoot cause
The v3.0.2 draft-release fallback asks the REST releases endpoint for 100 releases per page. REST embeds every release's asset metadata, so repositories with many release assets can return very large responses before a missing-tag release can be created. For
sagemath/sage, the first page was 37,415,077 bytes and took 11.12 seconds during reproduction.The GraphQL fallback requests only
databaseIdandtagName. A full REST release is then loaded only when the tag matches, so existing draft behavior is retained without downloading unrelated asset metadata.Validation
npm run fmtchecknpm run typechecknpm run buildnpm test(184 tests; coverage thresholds pass)sagemath/sagecomparison: 100-release REST page 37,415,077 bytes / 11.12 s; 100-node GraphQL metadata query 0.99 scxzhong/action-gh-release: REST tag lookup returned 404 while GraphQL returned the same release withisDraft: true; the temporary draft was deleted afterwardFixes #829