Show the caret at column 0 - #9
Merged
Merged
Conversation
An empty field publishes a caret at column 0, and `!cursor` read that as none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty field publishes a caret at column 0, and
cursorPositionguarded with!cursor— so no cursor was published until the first character was typed. Every empty input in every TextUI app was affected; the only thing marking the focused control was its border colour.Found from a form in another project where tabbing between empty fields showed nothing.
truestill means "here, at offset 0", so the guard rejects onlyundefined,nullandfalse.Tests: 2098 passing, lint and typecheck clean. The two column-0 cases in the new test fail without the fix.