Skip to content

feat: product rating and review system#56

Open
JorgeHB69 wants to merge 14 commits into
mainfrom
feat/jorge-heredia/product-rating-and-review-system
Open

feat: product rating and review system#56
JorgeHB69 wants to merge 14 commits into
mainfrom
feat/jorge-heredia/product-rating-and-review-system

Conversation

@JorgeHB69

Copy link
Copy Markdown
Contributor

What did I do?

  • Make a microservice for managing reviews
  • Handle CRUD operation with reviews
  • Provide a form to add reviews
  • Show all reviews on the page

Reviewers:

@JorgeHB69
JorgeHB69 force-pushed the feat/jorge-heredia/product-rating-and-review-system branch from d60c43e to 8a2a4cb Compare December 6, 2024 20:46
@denis-gandel

This comment was marked as resolved.

@denis-gandel

This comment was marked as resolved.

@denis-gandel

This comment was marked as resolved.

@denis-gandel

This comment was marked as resolved.

@denis-gandel

Copy link
Copy Markdown
Contributor
Screencast.from.2024-12-07.19-03-15.webm

https://drive.google.com/file/d/1EoJL-tsrRJT000xA5d4rE163uZO7cBgz/view?usp=sharing

If you use error messages to indicate comment problems, try to make them more descriptive, so that the user can understand the error, and it would also be good if you could avoid throwing the pop up to continue editing.

@denis-gandel

This comment was marked as resolved.

@denis-gandel

This comment was marked as resolved.

@denis-gandel

Copy link
Copy Markdown
Contributor

Screenshot from 2024-12-07 20-13-30

One of the requirements is that there is a character counter, but it is not visible in the UI.

Screenshot from 2024-12-07 20-14-22

@denis-gandel

This comment was marked as resolved.

@JorgeHB69

Copy link
Copy Markdown
Contributor Author

Screencast.from.2024-12-07.19-03-15.webm
https://drive.google.com/file/d/1EoJL-tsrRJT000xA5d4rE163uZO7cBgz/view?usp=sharing

If you use error messages to indicate comment problems, try to make them more descriptive, so that the user can understand the error, and it would also be good if you could avoid throwing the pop up to continue editing.

I can't reply to the cases where the message for validations is shown, the text field only has validation for max length

@JorgeHB69

Copy link
Copy Markdown
Contributor Author

The ratings should be equally visible from the product card, you can either remove that section of the card or you can display it.

This problem will be solved with the US: https://app.clickup.com/t/868av092p

@JeferssonCL
JeferssonCL self-requested a review December 9, 2024 07:25

@JeferssonCL JeferssonCL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@denis-gandel

Copy link
Copy Markdown
Contributor

Screencast.from.2024-12-07.19-03-15.webm
https://drive.google.com/file/d/1EoJL-tsrRJT000xA5d4rE163uZO7cBgz/view?usp=sharing
If you use error messages to indicate comment problems, try to make them more descriptive, so that the user can understand the error, and it would also be good if you could avoid throwing the pop up to continue editing.

I can't reply to the cases where the message for validations is shown, the text field only has validation for max length

Then it would be good that you simply delete or change to a more descriptive message that toast, as it becomes a bit confusing.

@denis-gandel

Copy link
Copy Markdown
Contributor

Screencast.from.2024-12-07.19-03-15.webm
Although the comment field and the requirement say that it must be optional, this does not happen in the Frontend part, since it detects it as empty, besides that although in the Backend part it lets you send a comment as optional, the way it is shown in the app is very bad.

Screenshot from 2024-12-07 20-07-44

I would suggest you to change those quotation marks to a “No comment” message or some other preferably, but avoid displaying those 2 quotation marks alone and without text.

https://drive.google.com/file/d/1ng_hkwPNgnJlJ4f8Iu6XD2s7UnuQUd3W/view?usp=sharing

The comment field is still mandatory

@denis-gandel

Copy link
Copy Markdown
Contributor

https://drive.google.com/file/d/1tnpA1gQBMR--j1tSRGwZ5miuuczOfAMt/view?usp=sharing

Now it does not allow me to make comments, besides if there is already a comment that is not mine it removes the option to make more comments.

@JorgeHB69

Copy link
Copy Markdown
Contributor Author

Screencast.from.2024-12-07.19-03-15.webm
Although the comment field and the requirement say that it must be optional, this does not happen in the Frontend part, since it detects it as empty, besides that although in the Backend part it lets you send a comment as optional, the way it is shown in the app is very bad.
Screenshot from 2024-12-07 20-07-44
I would suggest you to change those quotation marks to a “No comment” message or some other preferably, but avoid displaying those 2 quotation marks alone and without text.

https://drive.google.com/file/d/1ng_hkwPNgnJlJ4f8Iu6XD2s7UnuQUd3W/view?usp=sharing

The comment field is still mandatory

Be sure that you are on the updated branch because the quotation marks were solved. Don't be shown for empty comments.

@denis-gandel

Copy link
Copy Markdown
Contributor

https://drive.google.com/file/d/15Pj6YkocUHZilAquMRoNC7_H8WA1LPi0/view?usp=sharing

When a comment first comes out as invalid, it does not allow you to publish other comments that would be valid, and it even takes away your permission to upload your opinion.

@denis-gandel denis-gandel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants