Skip to content

opt: connection returns the result after calling remove method #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nobodyiam merged 1 commit into from
Oct 18, 2025
Merged

opt: connection returns the result after calling remove method #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/com/alipay/remoting/Connection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ public Set<String> getPoolKeys() {
*
* @param poolKey connection pool key
*/
public void removePoolKey(String poolKey) {
poolKeys.remove(poolKey);
public boolean removePoolKey(String poolKey) {
return poolKeys.remove(poolKey);
}

/**
Expand Down Expand Up @@ -410,8 +410,8 @@ public Object setAttributeIfAbsent(String key, Object value) {
*
* @param key attribute key
*/
public void removeAttribute(String key) {
attributes.remove(key);
public Object removeAttribute(String key) {
return attributes.remove(key);
}

/**
Expand Down
Loading