[CMake] Use find or fetch mechanism for nlohmann json - #5775
Merged
fredroy merged 2 commits intoNov 25, 2025
Conversation
olivier-roussel
changed the title
olivier-roussel
added
pr: status to review
olivier-roussel
force-pushed
the
externalize_nlohmann_json
branch
from
November 12, 2025 13:56
d75e560 to
1d1a105
Compare
olivier-roussel
force-pushed
the
externalize_nlohmann_json
branch
from
November 12, 2025 15:59
1d1a105 to
10404de
Compare
10 tasks
bakpaul
approved these changes
Nov 20, 2025
Contributor
Author
|
@bakpaul @hugtalbot I confirm that this works with |
olivier-roussel
added
pr: status ready
Contributor
|
[ci-build][with-all-tests] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the effort to make SOFA compatible with conda-forge rules, this replaces the use of embedded code for nlohmann json header-only library by a "find or fetch" mechanism as used for other dependencies. This has been outlined in a recent review of conda-forge SOFA PR (conda-forge/staged-recipes#23085).
Note that nlohmann json lib is used in both Sofa.Core and Sofa.Helper modules.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if