Fix release pipeline and bump to 1.5.1 - #15
Merged
Conversation
- release.yml: trigger only on published release, not tag push, to stop the duplicate concurrent run that raced and failed the WordPress.org SVN tag commit - .distignore: exclude dist/ and the generated zip so build artifacts stop leaking into the distributed plugin and the wp.org SVN - Bump version to 1.5.1 across plugin header, VERSION, readme.txt, package.json - Add 1.5.1 changelog entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every release since 1.3.1 produced one failed Release workflow run.
create-release.ymlpublishes a GitHub release, which both publishes the release and pushes its tag.release.ymllistened to both events, so two jobs ran concurrently and raced the WordPress.org SVNsvn cp … tags/<version>— the loser died withE160024: Conflict. The 1.5.0 deploy still succeeded (winning twin), but the red X was misleading.Separately, the "Build plugin zip" step wrote
dist/(a full nested copy) andcache-tags-for-cloudflare.zipinto the checkout root, and.distignoredidn't exclude them, so the 10up deploy swept both intotrunkandtags/1.5.0.Changes
release: [published]; drop the duplicatepush: tagstrigger so a single deploy runs per release./distand/cache-tags-for-cloudflare.zipso build artifacts stop shipping to users and the wp.org SVN.VERSION, readme.txt, package.json) with changelog entries.Verification
composer run check— phpcs + phpstan clean, phpunit 44 tests / 58 assertionsnpm run test:js— 14 testsnpm run lint:js— cleannpm run build— output unchanged (no functional plugin code touched)