Improve pure Ruby selector compatibility on JRuby#192
Closed
samuel-williams-shopify wants to merge 13 commits into
Closed
Improve pure Ruby selector compatibility on JRuby#192samuel-williams-shopify wants to merge 13 commits into
samuel-williams-shopify wants to merge 13 commits into
Conversation
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Assisted-By: devx/242ffd92-f36a-421a-88b9-270e5488162a
Contributor
Author
|
Superseded by #193, which recreates the JRuby compatibility work on a fresh branch from main without the old interrupt-fix diagnostic history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bundle exec rubocopbundle exec bake testinterrupt-fix(98b204b)Note: Windows jobs are still failing separately and were not part of this JRuby-focused pass.