Conversation
Added MySQL service for testing and updated PHP extensions.
Removed the migration step from the testing workflow.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the test infrastructure and Laravel version compatibility for the Thai Addresses package. The changes improve database seeding efficiency, add environment variable management, and update dependency versions.
- Centralizes database seeding in the TestCase setup to avoid redundant seeding calls
- Adds comprehensive environment variable loading with support for
.env.testingfiles - Updates package dependencies to support Laravel 12.0 and newer versions of testing tools
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/TestCase.php | Adds environment variable loading, centralizes database seeding, and improves database configuration |
| tests/Feature/UserTest.php | Removes redundant beforeEach seeding call |
| tests/Feature/DatabaseSeederTest.php | Removes redundant beforeEach seeding call and adds clarifying comment |
| phpunit.xml.dist | Simplifies PHPUnit configuration and updates database environment variables |
| database/seeders/*.php | Adds table existence checks before seeding operations |
| composer.json | Updates dependency versions to support Laravel 12.0 and newer tool versions |
| .phpunit.cache/test-results | Updates test results cache with new Pest version |
| .github/workflows/run-tests.yml | Adds MySQL service, updates matrix to include Laravel 12.0, and improves CI setup |
| .github/workflows/phpstan.yml | Updates PHP version from 8.0 to 8.3 |
| .env.testing.example | Adds example environment configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+144
to
+147
| // migrations ของ package | ||
| $this->loadMigrationsFrom(__DIR__.'/../database/migrations'); | ||
|
|
||
| // migrations ของ workbench (เช่น users table) |
There was a problem hiding this comment.
Consider translating these Thai comments to English: '// package migrations' and '// workbench migrations (e.g. users table)'
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.