chore: [AG-290] Non-Forgeable Trust#42
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
dan-arpino
force-pushed
the
chore/AG-290-non-forgeable-trust
branch
from
c82cac5 to
b3da2ef
Compare
jboerma-snyk
approved these changes
Jun 17, 2026
jboerma-snyk
left a comment
jboerma-snyk
left a comment
There was a problem hiding this comment.
LGTM! Small option to wrap up the POST check.
Comment on lines
+264
to
+270
| @@ -243,6 +265,9 @@ func (t *FolderTrust) addHttpHandlers(logger zerolog.Logger, mux *http.ServeMux, | |||
| http.Error(w, "Method not allowed", http.StatusMethodNotAllowed) | |||
| return | |||
| } | |||
| if !validateRequest(w, r) { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
I'm wondering if the POST check should be wrapped up in validateRequest
Contributor
Author
There was a problem hiding this comment.
Good call, let me wrap that in too!
dan-arpino
force-pushed
the
chore/AG-290-non-forgeable-trust
branch
from
b3da2ef to
8288c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making Trust less Forgeable by randomizing port (instead of predictable) and rejecting cross-origin requests
Checklist
make generate)make lint-fix)