feat: upload file content to file upload api - #165
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2f6f8c5 to
b6c1827
Compare
| } | ||
| } | ||
|
|
||
| func WithInputUploadRevision(id string, localFilePath string, repoUrl *string) CreateTestOption { |
There was a problem hiding this comment.
Compared to WithInputBundle we can't set the branch, commit_id, or limit_test_to_files properties based on the spec.
I know that limit_test_to_files is used only for IDE analyses, but I'm not sure about the other 2 properties.
This is something I need to check with code-owners
e33a7bf to
5423778
Compare
d81f57d to
743c6ad
Compare
| ) | ||
| scanner.analysisOrchestrator = analysisOrchestrator | ||
|
|
||
| orgID := uuid.MustParse(scanner.config.Organization()) |
There was a problem hiding this comment.
Question to clarify with code integrations.
Is it safe to use mustParse here? The testService client already uses must parse to convert the orgId string to a UUID.
There was a problem hiding this comment.
This is safe.
The exploration test shows --org=<invalid uuid> gets ignored by the CLI. User experience will default to the user's default org.
743c6ad to
9c0db59
Compare
PR Reviewer Guide 🔍
|
Integrate with the FUA client from GAF and use FUA to upload and execute the analysis.
This PR relies on a small change in GAF, which I'm in the processing of getting ready to merge:
snyk/go-application-framework#666
I've successfully tested these changes with a local build of the CLI.
Interaction id logs
What I will address before merging this PR:
What I will address in a follow-up PR: