Skip to content

chore: change ownership - #163

Merged
ahmed-agabani-snyk merged 1 commit into
mainfrom
chore/update-contributer-md
Jul 17, 2026
Merged

chore: change ownership#163
ahmed-agabani-snyk merged 1 commit into
mainfrom
chore/update-contributer-md

Conversation

@ahmed-agabani-snyk

Copy link
Copy Markdown
Contributor

Description

Changes ownership

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

@ahmed-agabani-snyk
ahmed-agabani-snyk requested a review from a team as a code owner July 17, 2026 11:27
@CLAassistant

CLAassistant commented Jul 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@snyk-io

snyk-io Bot commented Jul 17, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Secrets 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-io

snyk-io Bot commented Jul 17, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@ahmed-agabani-snyk
ahmed-agabani-snyk force-pushed the chore/update-contributer-md branch from 4578bac to 210a733 Compare July 17, 2026 11:29
@snyk-pr-review-bot

Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Breaking Auth Change 🟠 [major]

Renaming the authentication environment variable from SMOKE_TEST_TOKEN to SNYK_TOKEN without a fallback is a breaking change for local development and downstream projects (e.g., snyk-ls, Snyk CLI) that use this utility. Existing environments with SMOKE_TEST_TOKEN set will now silently fail to authenticate, as the code falls back to generating a random UUID (which will result in 401/403 errors from the Snyk API) instead of using the provided legacy token.

token := os.Getenv("SNYK_TOKEN")
Opaque Test Config 🟡 [minor]

Changing the hardcoded organization UUID while simultaneously removing the documentation in CONTRIBUTING.md that specified the target environment (app.dev.snyk.io) makes the test suite's requirements opaque. This makes it difficult for contributors to diagnose authorization failures or set up their own tokens with correct permissions for the new organization.

return "81c4528c-665a-43da-a0a7-581277288bf3"
📚 Repository Context Analyzed

This review considered 4 relevant code sections from 4 files (average relevance: 0.74)

🤖 Repository instructions applied (from AGENTS.md)

Comment thread CONTRIBUTING.md
```

If writing unit tests, use the mocks generated by [GoMock](https://github.com/golang/mock) by running `make generate`.
If writing unit tests, use the mocks generated by [GoMock](https://github.com/golang/mock) by running `make generate`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to migrate this as some point. This repo is achieved, we should use https://github.com/uber-go/mock

@minsiyang minsiyang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ahmed-agabani-snyk
ahmed-agabani-snyk merged commit e807c5c into main Jul 17, 2026
18 checks passed
@ahmed-agabani-snyk
ahmed-agabani-snyk deleted the chore/update-contributer-md branch July 17, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants