refactor: always use native Snyk Code workflow - #160
Draft
fsargent wants to merge 1 commit into
Draft
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Remove the remaining legacy CLI dispatch branch from the code-client-go workflow. The
code.testworkflow now always recordsimplementation=native, registers the SCLE auth URL when needed, and runscode_workflow.EntryPointNativedirectly.This also removes the native/consistent-ignores feature-flag gate from
Init, deletes theEntryPointLegacywrapper, updates tests that previously exercised the legacy fallback, and updates README workflow documentation.Checklist
Validation run locally:
make formatgo mod tidygo build ./...go test -cover ./...go test ./pkg/code ./internal/commands/code_workflowgofmt -w -l -e pkg/code/code.go pkg/code/code_test.go.bin/golangci-lint run --fix ./pkg/code/... ./internal/commands/code_workflow/...Known local validation blocker:
make generatecould not complete becausescripts/download-test-api.pyrequiresGITHUB_PATto be set.🚨 After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.