Show column name for events and entities - #1776
Show column name for events and entities#1776Miranda Wilson (mscwilson) wants to merge 7 commits into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
documentation | 03b8e11 | Commit Preview URL Branch Preview URL |
May 13 2026, 08:45 AM |
Writing reviewThis PR is mostly code, but it does introduce a small amount of user-facing prose in "In most warehouses:" reads as a sentence fragmentThe first paragraph is rendered inside a
The style guide favors complete sentences in prose. Suggest rephrasing to a full sentence, e.g.:
(And likewise for the entity variant with Ambiguous link sentence
This can be parsed two ways. The intended meaning is "for [Redshift, and older versions of the BigQuery Loader], see the querying overview" — but it can be misread as "the querying overview for [Redshift and older BigQuery Loader versions]" (i.e. an overview specific to those). It's also not explicit why the reader would click through. Consider leading with the exception:
That also makes the link text's destination concrete, which is a small win for accessibility and scannability. Two near-identical blocksThe event branch ( Other nits
Nothing blocking — the prose changes are small and the existing tone matches the rest of the docs. |
| </TabItem> | ||
|
|
||
| <TabItem value="redshift" label="Redshift & Postgres"> | ||
| <TabItem value="synapse" label="Synapse Analytics"> |
There was a problem hiding this comment.
Let’s remove Synapse altogether
| props.schema.properties && Object.keys(props.schema.properties).length > 0 | ||
| const warehouseNote = ( | ||
| <p> | ||
| Redshift and older versions of the BigQuery Loader use different names — |
There was a problem hiding this comment.
Snowflake also uses different names, we turn schema fields into camelCase
Updates the
SchemaPropertiescomponent to show the expected column name for that schema. Makes it easier for analysts to find where data has come from.