charts/snowplow-iglu-server: add ingress tls override (closes #351) - #352
Merged
Ian Arsenault (ianarsenault) merged 2 commits intoAug 1, 2026
Merged
Conversation
Ian Arsenault (ianarsenault)
marked this pull request as ready for review
July 31, 2026 20:58
Andy Hay (Andy-Hay)
approved these changes
Aug 1, 2026
Ian Arsenault (ianarsenault)
deleted the
iglu-chart-ingress-tls-override
branch
August 1, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings iglu-server chart in parity with service-deployment and common chart to support supplying an already existing TLS K8s Secret
Existing deployments are left as is, future deployments can supply a tlsSecretName with the ingress configuration.
Validation
Existing behaviour — no
tlsSecretName(unchanged)helm template iglu snowplow-iglu-server \ --set service.config.env.ACCEPT_LIMITED_USE_LICENSE=yes \ --set 'service.ingress.ingress-01.hostname=iglu\.example\.com' \ -s templates/iglu-ingress.yaml -s templates/certificate.yamlNew —
tlsSecretNamesuppliedNo cert-manager
Certificateis rendered for that host: