cmake: Stop requiring Boost.System as a compiled component - #217
Open
wvangeit wants to merge 2 commits into
Open
cmake: Stop requiring Boost.System as a compiled component#217wvangeit wants to merge 2 commits into
wvangeit wants to merge 2 commits into
Conversation
Boost.System has been header-only since Boost 1.69, and Dakota requires >= 1.70. Some package managers (e.g. Homebrew >= 1.87) no longer ship a separate libboost_system library, causing find_package(Boost COMPONENTS system) to fail. Remove system from the required COMPONENTS list and create a Boost::system INTERFACE IMPORTED target as a fallback when the package manager does not provide one. This keeps existing target_link_libraries(... Boost::system) calls working on all platforms.
Author
|
@rhoope @jadamstephens You think this would ever be merged / or implemented? Or should i close the PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boost.System has been header-only since Boost 1.69, and Dakota requires >= 1.70. Some package managers (e.g. Homebrew >= 1.87) no longer ship a separate libboost_system library, causing find_package(Boost COMPONENTS system) to fail.
Remove system from the required COMPONENTS list and create a Boost::system INTERFACE IMPORTED target as a fallback when the package manager does not provide one. This keeps existing target_link_libraries(... Boost::system) calls working on all platforms.