feat: Add support for Direct Valve Control for TRVs - #413
Open
Haxk20 wants to merge 1 commit into
Open
Conversation
Some TRVs (as example Sonoff) have the ability to be controlled via direct valve adjustments. We can make use of this in roommind by sending the power fraction directly to the TRV. The support is implemented in a way so it doesnt matter whether the TRV has support for opening and closing or only one of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Some TRVs (as example Sonoff) have the ability to be controlled via direct valve adjustments.
We can make use of this in roommind by sending the power fraction directly to the TRV.
The support is implemented in a way so it doesnt matter whether the TRV has support for opening and closing or only one of them.
I tried to keep it as simple as possible but there are still things to improve upon and would love feedback on this.
Why
Discussions #236 and #253 already describe why this was done.
But to keep it very simple the radiator doesnt need to turn on for 5 minutes on full power if realistically holding the power at 20% would have saved battery on the TRV and also be more cost efficient since radiators like to hold on heat.
Checklist
pytest tests/ -v)cd frontend && npm run build)en.json,de.jsonandfr.json. (if applicable)