Harden manifest validation and action input handling - #2
Merged
Conversation
snapsynapse
marked this pull request as ready for review
July 10, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle-pathshell injection.hash: nullopt-outs and update-mode repair.Root cause
The action interpolated caller-controlled input directly into Bash source. The validator also conflated missing or malformed hashes with intentionally unhashed entries, allowing an invalid manifest to report success.
Impact
Validation now rejects missing, malformed, and duplicate hash fields. Git-backed bundles must use explicit
hash: nullfor intentional opt-outs. This is a breaking manifest-contract change and is therefore versioned as 5.0.0.Validation
.skillfreshness checksFollow-up
Path traversal, symlink handling, duplicate path entries, and the supported YAML-subset grammar remain policy questions. They are captured in a local ignored handoff and intentionally excluded from this PR.