Add ERWIN model implementation - #19
Draft
smsharma wants to merge 1 commit into
Draft
Conversation
Implement ERWIN (Efficient Hierarchical Transformer) model for point cloud data: - Added hierarchical ball tree construction - Implemented Ball Multi-Head Self-Attention (BMSA) - Created UNet-style encoder-decoder architecture - Added comprehensive tests for all components This implementation offers O(n) complexity instead of O(n²) through local ball attention and hierarchical representation learning.
|
haha Claude rocks! However, I don't think the code will work. Particularly,
I used Claude a lot when developing Erwin, but it required extensive parenting, especially when it came to anything related to ball tree handling. I cannot blame him for it since I use ball trees rather unorthodoxly, but it is something to keep in mind :) I am going to implement Erwin in JAX once I am done polishing it in PyTorch (the current repo is not the final one, e.g. there is no cross-ball interaction yet). If Claude does it before, I am afraid we have AGI on our hands haha |
|
I don't know if you intend to reimplement Erwin in JAX, but the Foreign Function Interface is one option to address the many of the issues discussed above, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Untested, generated by Claude Code.
Summary
Implementation Details
Note
The radius graph construction is not fully JIT-compatible when computing the graph structure dynamically. Users should pre-compute edges or provide them directly when using within JIT-compiled functions.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
This PR took ~10 minutes and ~$7 to generate.